Instead of copying cache just reference it as a const data source

Author: mfulb

agent/php_txn.c

@@ -1156,10 +1156,15 @@ nr_status_t nr_php_txn_begin(const char* appnames,
       && (NULL != NR_PHP_PROCESS_GLOBALS(composer_php_packages))) {
     nrl_verbosedebug(NRL_FRAMEWORK,
                      "composer packages already detected, using cached values");
+#if 0
     nr_php_packages_destroy(&NRPRG(txn)->php_packages);
     NRPRG(txn)->php_packages
         = nr_php_packages_clone(NR_PHP_PROCESS_GLOBALS(composer_php_packages));
     nrl_verbosedebug(NRL_FRAMEWORK, "composer packages cloned from cache");
+#else
+    nr_php_packages_set_known(NRPRG(txn)->php_packages,
+                              NR_PHP_PROCESS_GLOBALS(composer_php_packages));
+#endif
   }
 
   return NR_SUCCESS;

axiom/nr_php_packages.c

@@ -36,6 +36,15 @@ static inline const char* nr_php_package_source_priority_to_string(const nr_php_
   }
 }
 
+void nr_php_packages_set_known(nr_php_packages_t* pkgs,
+                               const nr_hashmap_t* known) {
+  if (NULL == pkgs || NULL == known) {
+    return;
+  }
+
+  pkgs->known_packages = known;
+}
+
 nr_php_package_t* nr_php_package_create_with_source(
     const char* name,
     const char* version,
@@ -154,6 +163,20 @@ nr_php_package_t* nr_php_packages_add_package(nr_php_packages_t* h,
     return NULL;
   }
 
+  // if package is in known packages then ignore
+
+  package = (nr_php_package_t*)nr_hashmap_get(
+      h->known_packages, p->package_name, nr_strlen(p->package_name));
+  if (NULL != package) {
+    if (package->source_priority <= p->source_priority
+        && 0 != nr_strcmp(package->package_version, p->package_version)) {
+      nr_free(package->package_version);
+      package->package_version = nr_strdup(p->package_version);
+    }
+    nr_php_package_destroy(p);
+    return NULL;
+  }
+
   // If package with the same key already exists, we will check if the value is
   // different. If it is different, then we will update the value of the package
   package = (nr_php_package_t*)nr_hashmap_get(h->data, p->package_name,

axiom/nr_php_packages.h

@@ -28,13 +28,17 @@ typedef struct _nr_php_package_t {
 
 typedef struct _nr_php_packages_t {
   nr_hashmap_t* data;
+  const nr_hashmap_t* known_packages;
 } nr_php_packages_t;
 
 typedef void(nr_php_packages_iter_t)(void* value,
                                      const char* name,
                                      size_t name_len,
                                      void* user_data);
 
+void nr_php_packages_set_known(nr_php_packages_t* pkgs,
+                               const nr_hashmap_t* known);
+
 /*
  * Purpose : Create a new php package with desired source priority. If the name is null, then no package will
  *           be created. If the version is null (version = NULL), then