fix: package info from composer wins [UNIT TESTS]

Add unit tests that verify the functionality  of ensuring that package
information obtained from composer has higher precedence over package
information obtained from the package itself (legacy method).

Author: lavarou

axiom/tests/test_php_packages.c

@@ -192,6 +192,64 @@ static void test_php_package_without_version(void) {
   nr_php_packages_destroy(&hm);
 }
 
+static void test_php_package_priority(void) {
+#define PACKAGE_NAME "vendor/package"
+#define NO_VERSION NULL
+#define PACKAGE_VERSION "1.0.0"
+#define COMPOSER_VERSION "1.0.1"
+  nr_php_package_t* legacy_package;
+  nr_php_package_t* composer_package;
+  nr_php_package_t* p;
+  nr_php_packages_t* hm = NULL;
+  int count;
+  char* legacy_versions[] = {
+      NO_VERSION, PACKAGE_VERSION};
+
+  // Package added with legacy priority first - version from composer should win
+  for (size_t i = 0; i < sizeof(legacy_versions)/sizeof(legacy_versions[0]); i++) {
+    legacy_package = nr_php_package_create(PACKAGE_NAME, legacy_versions[i]); // legacy priority
+    tlib_pass_if_int_equal("create package by uses legacy priority", NR_PHP_PACKAGE_SOURCE_LEGACY, legacy_package->source_priority);
+    composer_package = nr_php_package_create_with_source(PACKAGE_NAME, COMPOSER_VERSION, NR_PHP_PACKAGE_SOURCE_COMPOSER); // composer priority
+    tlib_pass_if_int_equal("create package by uses composer priority", NR_PHP_PACKAGE_SOURCE_COMPOSER, composer_package->source_priority);
+
+    hm = nr_php_packages_create();
+    // order of adding packages: legacy first, composer second
+    nr_php_packages_add_package(hm, legacy_package);
+    nr_php_packages_add_package(hm, composer_package);
+
+    count = nr_php_packages_count(hm);
+    tlib_pass_if_int_equal("add same package", 1, count);
+
+    p = (nr_php_package_t*)nr_hashmap_get(hm->data, PACKAGE_NAME, nr_strlen(PACKAGE_NAME));
+    tlib_pass_if_not_null("package exists", p);
+    tlib_pass_if_str_equal("package version from composer wins", COMPOSER_VERSION, p->package_version);
+
+    nr_php_packages_destroy(&hm);
+  }
+
+  // Package added with composer priority first - version from composer should win
+  for (size_t i = 0; i < sizeof(legacy_versions)/sizeof(legacy_versions[0]); i++) {
+    legacy_package = nr_php_package_create(PACKAGE_NAME, legacy_versions[i]); // legacy priority
+    tlib_pass_if_int_equal("create package by uses legacy priority", NR_PHP_PACKAGE_SOURCE_LEGACY, legacy_package->source_priority);
+    composer_package = nr_php_package_create_with_source(PACKAGE_NAME, COMPOSER_VERSION, NR_PHP_PACKAGE_SOURCE_COMPOSER); // composer priority
+    tlib_pass_if_int_equal("create package by uses composer priority", NR_PHP_PACKAGE_SOURCE_COMPOSER, composer_package->source_priority);
+
+    hm = nr_php_packages_create();
+    // order of adding packages: legacy first, composer second
+    nr_php_packages_add_package(hm, composer_package);
+    nr_php_packages_add_package(hm, legacy_package);
+
+    count = nr_php_packages_count(hm);
+    tlib_pass_if_int_equal("add same package", 1, count);
+
+    p = (nr_php_package_t*)nr_hashmap_get(hm->data, PACKAGE_NAME, nr_strlen(PACKAGE_NAME));
+    tlib_pass_if_not_null("package exists", p);
+    tlib_pass_if_str_equal("package version from composer wins", COMPOSER_VERSION, p->package_version);
+
+    nr_php_packages_destroy(&hm);
+  }
+}
+
 tlib_parallel_info_t parallel_info
     = {.suggested_nthreads = -1, .state_size = 0};
 
@@ -203,4 +261,5 @@ void test_main(void* p NRUNUSED) {
   test_php_packages_to_json();
   test_php_package_exists_in_hashmap();
   test_php_package_without_version();
-}
+  test_php_package_priority();
+}