Cache composer api packages so these are considered each requst #1105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1105 +/- ##
==========================================
- Coverage 78.11% 78.07% -0.05%
==========================================
Files 193 193
Lines 27979 28036 +57
==========================================
+ Hits 21857 21888 +31
- Misses 6122 6148 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lavarou
force-pushed
the
fix/cache-composer-api-packages
branch
from
f9fcfcc to
2cf5726
Compare
mfulb
commented
Aug 6, 2025
| = nr_php_packages_clone(NR_PHP_PROCESS_GLOBALS(composer_php_packages)); | ||
| nrl_verbosedebug(NRL_FRAMEWORK, "composer packages cloned from cache"); | ||
| #else | ||
| nrl_verbosedebug(NRL_INSTRUMENT, "passing known PHP packages = %p", |
There was a problem hiding this comment.
This code needs some wrapping conditional so it isn't used if agent is running Composer API every request.
Probably wrapping it with:
if (NR_PHP_PROCESS_GLOBALS(composer_api_per_process_detection)) {
...
}
|
This approach yielded reasonable performance, but the use of process global to store package info persistently is considered problematic. A different approach was discussed and finally adopted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.