fix(agent): fix legacy package detection issues #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Composer runtime API was used to get packages information in once per process configuration, don't generate packages information using legacy methods.
Don't generate packages information using legacy methods if Composer API was used to get packages information regardless if it's used once per process or once per request.
Test that legacy package information is not added after Composer API was successfully used.
There's no need for additional state to call Composer API only once per process - composer_packages_detected global state can be used for per-process detection as well as per-request.
When use Composer API once per process is set, prevent calling the API when calling Composer API fails for whatever reason. This also means that legacy package information will be used when Composer API call failed.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1107 +/- ##
=======================================
Coverage 78.11% 78.12%
=======================================
Files 193 193
Lines 27979 27989 +10
=======================================
+ Hits 21857 21866 +9
- Misses 6122 6123 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zsistla
approved these changes
Aug 8, 2025
bduranleau-nr
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Composer runtime API is used to get packages information, the
agent should not generate packages information using legacy methods.
This solves the problem of package data detected with the help of
Composer's runtime API not to be sent to the backend in environments
using “once-per-process” setting. The reason for is that the first
request generates package information using Composer's runtime API
but every next request only generates package information using legacy
method. This in conjunction with the fact that daemon is only sending
the last package information received from the daemon leads to a
situation that package information returned by Composer runtime API
is lost and never makes it to the backend.