Change out windows xfails

Author: TimPansino

tests/agent_features/conftest.py

@@ -34,5 +34,3 @@
 collector_agent_registration = collector_agent_registration_fixture(
     app_name="Python Agent Test (agent_features)", default_settings=_default_settings
 )
-
-FAILING_ON_WINDOWS = pytest.mark.xfail(sys.platform == "win32", reason="TODO: Fix this test on Windows")

tests/agent_features/test_async_generator_trace.py

@@ -16,7 +16,6 @@
 import time
 
 import pytest
-from conftest import FAILING_ON_WINDOWS
 from testing_support.fixtures import capture_transaction_metrics, validate_tt_parenting
 from testing_support.validators.validate_transaction_errors import validate_transaction_errors
 from testing_support.validators.validate_transaction_metrics import validate_transaction_metrics
@@ -209,7 +208,6 @@ async def _test():
     event_loop.run_until_complete(_test())
 
 
-@FAILING_ON_WINDOWS
 @validate_tt_parenting(("TransactionNode", [("FunctionNode", [("FunctionNode", [])])]))
 @validate_transaction_metrics(
     "test_async_generator_parents",

tests/agent_features/test_attribute.py

@@ -14,7 +14,6 @@
 
 import pytest
 import webtest
-from conftest import FAILING_ON_WINDOWS
 from testing_support.fixtures import (
     override_application_settings,
     validate_agent_attribute_types,
@@ -61,7 +60,6 @@ def target_wsgi_application(environ, start_response):
 _forgone_intrinsics = []
 
 
-@FAILING_ON_WINDOWS
 @validate_attributes("intrinsic", _required_intrinsics, _forgone_intrinsics)
 def test_intrinsics():
     target_application = webtest.TestApp(target_wsgi_application)
@@ -84,7 +82,6 @@ def test_intrinsics():
 _forgone_agent = []
 
 
-@FAILING_ON_WINDOWS
 @validate_attributes("agent", _required_agent, _forgone_agent)
 def test_agent():
     target_application = webtest.TestApp(target_wsgi_application)

tests/agent_features/test_attributes_in_action.py

@@ -51,7 +51,6 @@
 except SyntaxError:
     normal_asgi_application = None
 
-from conftest import FAILING_ON_WINDOWS
 
 URL_PARAM = "some_key"
 URL_PARAM2 = "second_key"
@@ -197,7 +196,6 @@ def test_error_in_transaction_default_settings(normal_application):
 _expected_attributes = {"agent": TRACE_ERROR_AGENT_KEYS, "user": USER_ATTRS, "intrinsic": ["trip_id"]}
 
 
-@FAILING_ON_WINDOWS
 @cat_enabled
 @validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
 @override_application_settings({})
@@ -265,7 +263,6 @@ def test_error_in_transaction_exclude_request_params(normal_application):
 _expected_attributes = {"agent": TRACE_ERROR_AGENT_KEYS, "user": USER_ATTRS, "intrinsic": ["trip_id"]}
 
 
-@FAILING_ON_WINDOWS
 @validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
 @override_application_settings(_override_settings)
 def test_transaction_trace_exclude_request_params(normal_application):
@@ -288,7 +285,6 @@ def test_error_in_transaction_capture_params_exclude_request_params(normal_appli
 _override_settings = {"capture_params": True, "transaction_tracer.attributes.exclude": ["request.parameters.*"]}
 
 
-@FAILING_ON_WINDOWS
 @validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
 @override_application_settings(_override_settings)
 def test_transaction_trace_capture_params_exclude_request_params(normal_application):
@@ -316,7 +312,6 @@ def test_error_in_transaction_include_request_params(normal_application):
 _expected_attributes = {"agent": AGENT_KEYS_ALL, "user": USER_ATTRS, "intrinsic": ["trip_id"]}
 
 
-@FAILING_ON_WINDOWS
 @validate_transaction_trace_attributes(_expected_attributes)
 @override_application_settings(_override_settings)
 def test_transaction_trace_include_request_params(normal_application):
@@ -398,7 +393,6 @@ def test_error_in_transaction_include_exclude(normal_application):
 }
 
 
-@FAILING_ON_WINDOWS
 @validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
 @override_application_settings(_override_settings)
 def test_transaction_trace_include_exclude(normal_application):
@@ -473,7 +467,6 @@ def test_error_in_transaction_exclude_user_attribute(normal_application):
 _expected_attributes = {"agent": TRACE_ERROR_AGENT_KEYS, "user": ["sunshine"], "intrinsic": ["trip_id"]}
 
 
-@FAILING_ON_WINDOWS
 @validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
 @override_application_settings(_override_settings)
 def test_transaction_trace_exclude_user_attribute(normal_application):
@@ -552,7 +545,6 @@ def test_error_in_transaction_exclude_agent_attribute(normal_application):
 }
 
 
-@FAILING_ON_WINDOWS
 @validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
 @override_application_settings(_override_settings)
 def test_transaction_trace_exclude_agent_attribute(normal_application):
@@ -610,7 +602,6 @@ def test_error_in_transaction_deprecated_capture_params_true(normal_application)
 _expected_attributes = {"agent": AGENT_KEYS_ALL, "user": USER_ATTRS, "intrinsic": ["trip_id"]}
 
 
-@FAILING_ON_WINDOWS
 @validate_transaction_trace_attributes(_expected_attributes)
 @override_application_settings(_override_settings)
 def test_transaction_trace_deprecated_capture_params_true(normal_application):
@@ -668,7 +659,6 @@ def test_error_in_transaction_deprecated_capture_params_false(normal_application
 _expected_attributes = {"agent": TRACE_ERROR_AGENT_KEYS, "user": USER_ATTRS, "intrinsic": ["trip_id"]}
 
 
-@FAILING_ON_WINDOWS
 @validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
 @override_application_settings(_override_settings)
 def test_transaction_trace_deprecated_capture_params_false(normal_application):
@@ -728,7 +718,6 @@ def test_error_in_transaction_exclude_intrinsic(normal_application):
 _expected_attributes = {"agent": TRACE_ERROR_AGENT_KEYS, "user": USER_ATTRS, "intrinsic": ["trip_id"]}
 
 
-@FAILING_ON_WINDOWS
 @validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
 @override_application_settings(_override_settings)
 def test_transaction_trace_exclude_intrinsic(normal_application):
@@ -785,7 +774,6 @@ def test_error_in_transaction_attributes_disabled(normal_application):
 _override_settings = {"transaction_tracer.attributes.enabled": False}
 
 
-@FAILING_ON_WINDOWS
 @validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
 @override_application_settings(_override_settings)
 def test_transaction_trace_attributes_disabled(normal_application):
@@ -843,7 +831,6 @@ def test_error_in_transaction_error_param_excluded(normal_application):
 _expected_attributes = {"agent": TRANS_EVENT_AGENT_KEYS, "user": USER_ATTRS, "intrinsic": []}
 
 
-@FAILING_ON_WINDOWS
 @validate_transaction_trace_attributes(_expected_attributes)
 @validate_transaction_event_attributes(_expected_attributes)
 @override_application_settings(_override_settings)

tests/agent_features/test_collector_payloads.py

@@ -14,7 +14,6 @@
 
 import pytest
 import webtest
-from conftest import FAILING_ON_WINDOWS
 from testing_support.fixtures import override_application_settings
 from testing_support.sample_applications import simple_app, simple_custom_event_app, simple_exceptional_app
 from testing_support.validators.validate_custom_event_collector_json import validate_custom_event_collector_json
@@ -47,13 +46,11 @@ def test_error_event_json():
         pass
 
 
-@FAILING_ON_WINDOWS
 @validate_tt_collector_json()
 def test_transaction_trace_json():
     normal_application.get("/")
 
 
-@FAILING_ON_WINDOWS
 @validate_tt_collector_json(exclude_request_uri=True)
 @override_application_settings({"attributes.exclude": {"request.uri"}})
 def test_transaction_trace_json_no_request_uri():

tests/agent_features/test_coroutine_trace.py

@@ -19,7 +19,6 @@
 import time
 
 import pytest
-from conftest import FAILING_ON_WINDOWS
 from testing_support.fixtures import capture_transaction_metrics, validate_tt_parenting
 from testing_support.validators.validate_transaction_errors import validate_transaction_errors
 from testing_support.validators.validate_transaction_metrics import validate_transaction_metrics
@@ -76,7 +75,6 @@ def _test():
     assert full_metrics[metric_key].total_call_time >= 0.2
 
 
-@FAILING_ON_WINDOWS
 @validate_tt_parenting(("TransactionNode", [("FunctionNode", [("FunctionNode", []), ("FunctionNode", [])])]))
 @validate_transaction_metrics(
     "test_coroutine_siblings",
@@ -248,7 +246,6 @@ def coro():
     gen.close()
 
 
-@FAILING_ON_WINDOWS
 @validate_tt_parenting(("TransactionNode", [("FunctionNode", [("FunctionNode", [])])]))
 @validate_transaction_metrics(
     "test_coroutine_parents",

tests/agent_features/test_coroutine_transaction.py

@@ -15,7 +15,6 @@
 import asyncio
 
 import pytest
-from conftest import FAILING_ON_WINDOWS
 from testing_support.fixtures import capture_transaction_metrics, override_generic_settings
 from testing_support.validators.validate_transaction_errors import validate_transaction_errors
 
@@ -91,7 +90,6 @@ async def task():
     test_matrix.append(native_coroutine_test)
 
 
-@FAILING_ON_WINDOWS
 @pytest.mark.parametrize("num_coroutines", (2,))
 @pytest.mark.parametrize("create_test_task", test_matrix)
 @pytest.mark.parametrize(

tests/agent_features/test_error_events.py

@@ -16,7 +16,6 @@
 import time
 
 import webtest
-from conftest import FAILING_ON_WINDOWS
 from testing_support.fixtures import (
     cat_enabled,
     make_cross_agent_headers,
@@ -75,7 +74,6 @@ def test_transaction_error_event_no_extra_attributes():
 }
 
 
-@FAILING_ON_WINDOWS
 @validate_error_event_sample_data(required_attrs=_intrinsic_attributes, required_user_attrs=True)
 def test_transaction_error_event_lotsa_attributes():
     test_environ = {
@@ -99,7 +97,6 @@ def test_transaction_error_event_lotsa_attributes():
 }
 
 
-@FAILING_ON_WINDOWS
 @validate_error_event_sample_data(required_attrs=_intrinsic_attributes, required_user_attrs=True)
 def test_transaction_error_background_task():
     test_environ = {"err_message": ERR_MESSAGE, "external": "2", "db": "2", "newrelic.set_background_task": True}

tests/agent_features/test_function_trace.py

@@ -14,7 +14,6 @@
 
 import time
 
-from conftest import FAILING_ON_WINDOWS
 from testing_support.fixtures import validate_tt_parenting
 from testing_support.validators.validate_transaction_metrics import validate_transaction_metrics
 
@@ -89,7 +88,6 @@ def test_function_trace_leading_slash_on_group():
 )
 
 
-@FAILING_ON_WINDOWS
 @validate_transaction_metrics(
     "test_function_trace:test_async_trace_overlapping_children",
     scoped_metrics=_test_async_trace_overlapping_children_scoped_metrics,

tests/agent_features/test_high_security_mode.py

@@ -17,7 +17,6 @@
 
 import pytest
 import webtest
-from conftest import FAILING_ON_WINDOWS
 from testing_support.fixtures import (
     override_application_settings,
     override_generic_settings,
@@ -706,7 +705,6 @@ def test_http_referrer_url_is_sanitized_in_hsm():
     target_application.get("/", extra_environ=environ)
 
 
-@FAILING_ON_WINDOWS
 @pytest.mark.parametrize("hsm_enabled", [True, False])
 def test_function_trace_params_dropped_in_hsm(hsm_enabled):
     @background_task()
@@ -724,7 +722,6 @@ def _test():
     _test()
 
 
-@FAILING_ON_WINDOWS
 @pytest.mark.parametrize("hsm_enabled", [True, False])
 def test_message_trace_params_dropped_in_hsm(hsm_enabled):
     @background_task()