Fixup: code review

hmstepanek · hmstepanek · commit 1216054bf2c9 · 2024-03-27T13:29:10.000-07:00
diff --git a/newrelic/api/ml_model.py b/newrelic/api/ml_model.py
@@ -58,8 +58,8 @@ def record_llm_feedback_event(trace_id, rating, category=None, message=None, met
             "id": feedback_event_id,
             "trace_id": trace_id,
             "rating": rating,
-            "category": category or "",
-            "message": message or "",
+            "category": category,
+            "message": message,
             "ingest_source": "Python",
         }
     )
diff --git a/tests/agent_features/test_configuration.py b/tests/agent_features/test_configuration.py
@@ -46,7 +46,6 @@
     global_settings_dump,
 )
 
-from testing_support.fixtures import override_generic_settings
 
 def function_to_trace():
     pass

Original file line number	Diff line number	Diff line change
`@@ -58,8 +58,8 @@ def record_llm_feedback_event(trace_id, rating, category=None, message=None, met`
`58`	`58`	`"id": feedback_event_id,`
`59`	`59`	`"trace_id": trace_id,`
`60`	`60`	`"rating": rating,`
`61`		`- "category": category or "",`
`62`		`- "message": message or "",`
	`61`	`+ "category": category,`
	`62`	`+ "message": message,`
`63`	`63`	`"ingest_source": "Python",`
`64`	`64`	`}`
`65`	`65`	`)`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,6 @@`
`46`	`46`	`global_settings_dump,`
`47`	`47`	`)`
`48`	`48`
`49`		`-from testing_support.fixtures import override_generic_settings`
`50`	`49`
`51`	`50`	`def function_to_trace():`
`52`	`51`	`pass`