agent_unittests: Skip all failing windows tests for now

Author: TimPansino

tests/agent_unittests/conftest.py

@@ -35,6 +35,9 @@
 )
 
 
+FAILING_ON_WINDOWS = pytest.mark.xfail(sys.platform == "win32", reason="TODO: Fix this test on Windows")
+
+
 class FakeProtos:
     Span = object()
     SpanBatch = object()

tests/agent_unittests/test_encoding_utils.py

@@ -12,6 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+import sys
 from pathlib import Path
 
 import pytest
@@ -64,19 +65,25 @@ def _generator():
     yield from range(1, 4)
 
 
+JSON_ENCODE_TESTS = [
+    (10, "10"),
+    (10.0, "10.0"),
+    ("my_string", '"my_string"'),
+    (b"my_bytes", '"my_bytes"'),
+    ({"id": 1, "name": "test", "NoneType": None}, '{"id":1,"name":"test","NoneType":null}'),
+    (_generator(), "[1,2,3]"),
+    (tuple(range(4, 7)), "[4,5,6]"),
+]
+
+# Add a Path object test that's platform dependent
+if sys.platform == "win32":
+    JSON_ENCODE_TESTS.append((Path("test\\path\\file.txt"), '"test\\\\path\\\\file.txt"'))
+else:
+    JSON_ENCODE_TESTS.append((Path("test/path/file.txt"), '"test/path/file.txt"'))
+
+
 @pytest.mark.parametrize(
-    "input_,expected",
-    [
-        (10, "10"),
-        (10.0, "10.0"),
-        ("my_string", '"my_string"'),
-        (b"my_bytes", '"my_bytes"'),
-        ({"id": 1, "name": "test", "NoneType": None}, '{"id":1,"name":"test","NoneType":null}'),
-        (_generator(), "[1,2,3]"),
-        (tuple(range(4, 7)), "[4,5,6]"),
-        (Path("test/path/file.txt"), '"test/path/file.txt"'),
-    ],
-    ids=["int", "float", "str", "bytes", "dict", "generator", "iterable", "Path"],
+    "input_,expected", JSON_ENCODE_TESTS, ids=["int", "float", "str", "bytes", "dict", "generator", "iterable", "Path"]
 )
 def test_json_encode(input_, expected):
     output = json_encode(input_)

tests/agent_unittests/test_harvest_loop.py

@@ -18,6 +18,7 @@
 from pathlib import Path
 
 import pytest
+from conftest import FAILING_ON_WINDOWS
 from testing_support.fixtures import failing_endpoint, function_not_called, override_generic_settings
 
 from newrelic.common.agent_http import DeveloperModeClient
@@ -745,6 +746,7 @@ def _test():
     assert "metric_data" in endpoints_called
 
 
+@FAILING_ON_WINDOWS
 @failing_endpoint("analytic_event_data", call_number=2)
 @override_generic_settings(settings, {"developer_mode": True, "license_key": "**NOT A LICENSE KEY**"})
 def test_reset_synthetics_events():
@@ -858,6 +860,7 @@ def test_default_events_harvested(allowlist_event):
     assert app._stats_engine.metrics_count() == 4
 
 
+@FAILING_ON_WINDOWS
 @failing_endpoint("analytic_event_data")
 @override_generic_settings(settings, {"developer_mode": True, "agent_limits.merge_stats_maximum": 0})
 def test_infinite_merges():

tests/agent_unittests/test_http_client.py

@@ -20,6 +20,7 @@
 from io import StringIO
 
 import pytest
+from conftest import FAILING_ON_WINDOWS
 from testing_support.certs import CERT_PATH
 from testing_support.mock_external_http_server import MockExternalHTTPServer
 
@@ -226,6 +227,7 @@ def test_http_close_connection_in_context_manager():
         client.close_connection()
 
 
+@FAILING_ON_WINDOWS
 @pytest.mark.parametrize(
     "client_cls,method,threshold",
     (