Enable ruff built in linter rules (#1356)

* Enable ruff linter

* Fix RUF010 explicit-f-string-type-conversion

* Fix RUF021 parenthesize-chained-operators

* Fix RUF005 collection-literal-concatenation

* Fix RUF022 unsorted-dunder-all

* Remove incorrect type annotations from tests

* Fix RUF034 useless-if-else

* Disable 1 instance of RUF006 asyncio-dangling-task

* Fix RUF015 unnecessary-iterable-allocation-for-first-element

* Fix RUF012 mutable-class-default

* Ignore unicode characters in LLM responses

* Permanently disable flake8-self linter

* Ruff format

* Fix new issues

* Remove unused noqa directive

Author: TimPansino

.github/workflows/get-envs.py

@@ -26,7 +26,7 @@ def main(f):
     joined_envs = ",".join(filtered_envs)
 
     assert joined_envs, (  # noqa: S101
-        f"No environments found.\nenvironments = {str(environments)}\nGROUP_NUMBER = {GROUP_NUMBER + 1}\nTOTAL_GROUPS = {TOTAL_GROUPS}"
+        f"No environments found.\nenvironments = {environments!s}\nGROUP_NUMBER = {GROUP_NUMBER + 1}\nTOTAL_GROUPS = {TOTAL_GROUPS}"
     )
     print(joined_envs)
 

newrelic/api/application.py

@@ -22,9 +22,9 @@
 
 class Application:
     _lock = threading.Lock()
-    _instances = {}
+    _instances = {}  # noqa: RUF012
 
-    _delayed_callables = {}
+    _delayed_callables = {}  # noqa: RUF012
 
     @staticmethod
     def _instance(name, activate=True):

newrelic/api/html_insertion.py

@@ -78,7 +78,7 @@ def insert_at_index(index):
     xua_meta = _xua_meta_re.search(data)
     charset_meta = _charset_meta_re.search(data)
 
-    index = max(xua_meta and xua_meta.end() or 0, charset_meta and charset_meta.end() or 0)
+    index = max((xua_meta and xua_meta.end()) or 0, (charset_meta and charset_meta.end()) or 0)
 
     if index:
         return insert_at_index(index)

newrelic/api/log.py

@@ -131,7 +131,7 @@ def format(self, record):
 
 
 class NewRelicLogForwardingHandler(logging.Handler):
-    IGNORED_LOG_RECORD_KEYS = {"message", "msg"}
+    IGNORED_LOG_RECORD_KEYS = frozenset(("message", "msg"))
 
     def emit(self, record):
         try:

newrelic/api/time_trace.py

@@ -436,7 +436,7 @@ def notice_error(self, error=None, attributes=None, expected=None, ignore=None,
                             _, error_group_name = process_user_attribute("error.group.name", error_group_name_raw)
                             if error_group_name is None or not isinstance(error_group_name, str):
                                 raise ValueError(
-                                    f"Invalid attribute value for error.group.name. Expected string, got: {repr(error_group_name_raw)}"
+                                    f"Invalid attribute value for error.group.name. Expected string, got: {error_group_name_raw!r}"
                                 )
                     except Exception:
                         _logger.error(

newrelic/common/agent_http.py

@@ -283,7 +283,7 @@ def __init__(
             else:
                 self._host = proxy.host
                 self._port = proxy.port or 443
-                self._prefix = f"{self.PREFIX_SCHEME + host}:{str(port)}"
+                self._prefix = f"{self.PREFIX_SCHEME + host}:{port!s}"
                 urlopen_kwargs["assert_same_host"] = False
                 if proxy_headers:
                     self._headers.update(proxy_headers)
@@ -501,7 +501,7 @@ class ApplicationModeClient(SupportabilityMixin, HttpClient):
 
 
 class DeveloperModeClient(SupportabilityMixin, BaseClient):
-    RESPONSES = {
+    RESPONSES = {  # noqa: RUF012
         "preconnect": {"redirect_host": "fake-collector.newrelic.com"},
         "agent_settings": [],
         "connect": {

newrelic/common/encoding_utils.py

@@ -486,7 +486,7 @@ def text(self):
         if pr:
             pr = f"{pr:.6f}".rstrip("0").rstrip(".")
 
-        payload = f"0-0-{self['ac']}-{self['ap']}-{self.get('id', '')}-{self.get('tx', '')}-{'1' if self.get('sa') else '0'}-{pr}-{str(self['ti'])}"
+        payload = f"0-0-{self['ac']}-{self['ap']}-{self.get('id', '')}-{self.get('tx', '')}-{'1' if self.get('sa') else '0'}-{pr}-{self['ti']!s}"
         return f"{self.get('tk', self['ac'])}@nr={payload}"
 
     @classmethod

newrelic/common/utilization.py

@@ -161,7 +161,7 @@ class AWSUtilization(CommonUtilization):
     METADATA_HOST = "169.254.169.254"
     METADATA_PATH = "/latest/dynamic/instance-identity/document"
     METADATA_TOKEN_PATH = "/latest/api/token"  # noqa: S105
-    HEADERS = {"X-aws-ec2-metadata-token-ttl-seconds": "21600"}
+    HEADERS = {"X-aws-ec2-metadata-token-ttl-seconds": "21600"}  # noqa: RUF012
     VENDOR_NAME = "aws"
     _utilization_data = None
 
@@ -219,18 +219,18 @@ def fetch(cls):
 class AzureUtilization(CommonUtilization):
     METADATA_HOST = "169.254.169.254"
     METADATA_PATH = "/metadata/instance/compute"
-    METADATA_QUERY = {"api-version": "2017-03-01"}
+    METADATA_QUERY = {"api-version": "2017-03-01"}  # noqa: RUF012
     EXPECTED_KEYS = ("location", "name", "vmId", "vmSize")
-    HEADERS = {"Metadata": "true"}
+    HEADERS = {"Metadata": "true"}  # noqa: RUF012
     VENDOR_NAME = "azure"
 
 
 class AzureFunctionUtilization(CommonUtilization):
     METADATA_HOST = "169.254.169.254"
     METADATA_PATH = "/metadata/instance/compute"
-    METADATA_QUERY = {"api-version": "2017-03-01"}
+    METADATA_QUERY = {"api-version": "2017-03-01"}  # noqa: RUF012
     EXPECTED_KEYS = ("faas.app_name", "cloud.region")
-    HEADERS = {"Metadata": "true"}
+    HEADERS = {"Metadata": "true"}  # noqa: RUF012
     VENDOR_NAME = "azurefunction"
 
     @staticmethod
@@ -264,10 +264,10 @@ def get_values(cls, response):
 
 class GCPUtilization(CommonUtilization):
     EXPECTED_KEYS = ("id", "machineType", "name", "zone")
-    HEADERS = {"Metadata-Flavor": "Google"}
+    HEADERS = {"Metadata-Flavor": "Google"}  # noqa: RUF012
     METADATA_HOST = "metadata.google.internal"
     METADATA_PATH = "/computeMetadata/v1/instance/"
-    METADATA_QUERY = {"recursive": "true"}
+    METADATA_QUERY = {"recursive": "true"}  # noqa: RUF012
     VENDOR_NAME = "gcp"
 
     @classmethod

newrelic/config.py

@@ -50,7 +50,7 @@
 )
 from newrelic.core.config import Settings, apply_config_setting, default_host, fetch_config_setting
 
-__all__ = ["initialize", "filter_app_factory"]
+__all__ = ["filter_app_factory", "initialize"]
 
 _logger = logging.getLogger(__name__)
 

newrelic/core/agent.py

@@ -121,8 +121,8 @@ class Agent:
 
     _instance_lock = threading.Lock()
     _instance = None
-    _startup_callables = []
-    _registration_callables = {}
+    _startup_callables = []  # noqa: RUF012
+    _registration_callables = {}  # noqa: RUF012
 
     @staticmethod
     def run_on_startup(callable):  # noqa: A002
@@ -781,7 +781,7 @@ def shutdown_agent(timeout=None):
 
 def register_data_source(source, application=None, name=None, settings=None, **properties):
     agent = agent_instance()
-    agent.register_data_source(source, application and application.name or None, name, settings, **properties)
+    agent.register_data_source(source, (application and application.name) or None, name, settings, **properties)
 
 
 def _remove_thread_utilization():