Skip to content

Commit 286a60a

Browse files
committed
agent_features: Skip all failing windows tests for now
1 parent a74c143 commit 286a60a

15 files changed

+59
-2
lines changed

tests/agent_features/conftest.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15+
import sys
16+
17+
import pytest
1518
from testing_support.fixture.event_loop import event_loop
1619
from testing_support.fixtures import collector_agent_registration_fixture, collector_available_fixture
1720
from testing_support.fixtures import newrelic_caplog as caplog
@@ -31,3 +34,5 @@
3134
collector_agent_registration = collector_agent_registration_fixture(
3235
app_name="Python Agent Test (agent_features)", default_settings=_default_settings
3336
)
37+
38+
FAILING_ON_WINDOWS = pytest.mark.xfail(sys.platform == "win32", reason="TODO: Fix this test on Windows")

tests/agent_features/test_async_generator_trace.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@
1313
# limitations under the License.
1414

1515
import functools
16-
import sys
1716
import time
1817

1918
import pytest
19+
from conftest import FAILING_ON_WINDOWS
2020
from testing_support.fixtures import capture_transaction_metrics, validate_tt_parenting
2121
from testing_support.validators.validate_transaction_errors import validate_transaction_errors
2222
from testing_support.validators.validate_transaction_metrics import validate_transaction_metrics
@@ -209,6 +209,7 @@ async def _test():
209209
event_loop.run_until_complete(_test())
210210

211211

212+
@FAILING_ON_WINDOWS
212213
@validate_tt_parenting(("TransactionNode", [("FunctionNode", [("FunctionNode", [])])]))
213214
@validate_transaction_metrics(
214215
"test_async_generator_parents",

tests/agent_features/test_attribute.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
import pytest
1616
import webtest
17+
from conftest import FAILING_ON_WINDOWS
1718
from testing_support.fixtures import (
1819
override_application_settings,
1920
validate_agent_attribute_types,
@@ -60,6 +61,7 @@ def target_wsgi_application(environ, start_response):
6061
_forgone_intrinsics = []
6162

6263

64+
@FAILING_ON_WINDOWS
6365
@validate_attributes("intrinsic", _required_intrinsics, _forgone_intrinsics)
6466
def test_intrinsics():
6567
target_application = webtest.TestApp(target_wsgi_application)
@@ -82,6 +84,7 @@ def test_intrinsics():
8284
_forgone_agent = []
8385

8486

87+
@FAILING_ON_WINDOWS
8588
@validate_attributes("agent", _required_agent, _forgone_agent)
8689
def test_agent():
8790
target_application = webtest.TestApp(target_wsgi_application)

tests/agent_features/test_attributes_in_action.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
except SyntaxError:
5252
normal_asgi_application = None
5353

54+
from conftest import FAILING_ON_WINDOWS
5455

5556
URL_PARAM = "some_key"
5657
URL_PARAM2 = "second_key"
@@ -196,6 +197,7 @@ def test_error_in_transaction_default_settings(normal_application):
196197
_expected_attributes = {"agent": TRACE_ERROR_AGENT_KEYS, "user": USER_ATTRS, "intrinsic": ["trip_id"]}
197198

198199

200+
@FAILING_ON_WINDOWS
199201
@cat_enabled
200202
@validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
201203
@override_application_settings({})
@@ -263,6 +265,7 @@ def test_error_in_transaction_exclude_request_params(normal_application):
263265
_expected_attributes = {"agent": TRACE_ERROR_AGENT_KEYS, "user": USER_ATTRS, "intrinsic": ["trip_id"]}
264266

265267

268+
@FAILING_ON_WINDOWS
266269
@validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
267270
@override_application_settings(_override_settings)
268271
def test_transaction_trace_exclude_request_params(normal_application):
@@ -285,6 +288,7 @@ def test_error_in_transaction_capture_params_exclude_request_params(normal_appli
285288
_override_settings = {"capture_params": True, "transaction_tracer.attributes.exclude": ["request.parameters.*"]}
286289

287290

291+
@FAILING_ON_WINDOWS
288292
@validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
289293
@override_application_settings(_override_settings)
290294
def test_transaction_trace_capture_params_exclude_request_params(normal_application):
@@ -312,6 +316,7 @@ def test_error_in_transaction_include_request_params(normal_application):
312316
_expected_attributes = {"agent": AGENT_KEYS_ALL, "user": USER_ATTRS, "intrinsic": ["trip_id"]}
313317

314318

319+
@FAILING_ON_WINDOWS
315320
@validate_transaction_trace_attributes(_expected_attributes)
316321
@override_application_settings(_override_settings)
317322
def test_transaction_trace_include_request_params(normal_application):
@@ -393,6 +398,7 @@ def test_error_in_transaction_include_exclude(normal_application):
393398
}
394399

395400

401+
@FAILING_ON_WINDOWS
396402
@validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
397403
@override_application_settings(_override_settings)
398404
def test_transaction_trace_include_exclude(normal_application):
@@ -467,6 +473,7 @@ def test_error_in_transaction_exclude_user_attribute(normal_application):
467473
_expected_attributes = {"agent": TRACE_ERROR_AGENT_KEYS, "user": ["sunshine"], "intrinsic": ["trip_id"]}
468474

469475

476+
@FAILING_ON_WINDOWS
470477
@validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
471478
@override_application_settings(_override_settings)
472479
def test_transaction_trace_exclude_user_attribute(normal_application):
@@ -545,6 +552,7 @@ def test_error_in_transaction_exclude_agent_attribute(normal_application):
545552
}
546553

547554

555+
@FAILING_ON_WINDOWS
548556
@validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
549557
@override_application_settings(_override_settings)
550558
def test_transaction_trace_exclude_agent_attribute(normal_application):
@@ -602,6 +610,7 @@ def test_error_in_transaction_deprecated_capture_params_true(normal_application)
602610
_expected_attributes = {"agent": AGENT_KEYS_ALL, "user": USER_ATTRS, "intrinsic": ["trip_id"]}
603611

604612

613+
@FAILING_ON_WINDOWS
605614
@validate_transaction_trace_attributes(_expected_attributes)
606615
@override_application_settings(_override_settings)
607616
def test_transaction_trace_deprecated_capture_params_true(normal_application):
@@ -659,6 +668,7 @@ def test_error_in_transaction_deprecated_capture_params_false(normal_application
659668
_expected_attributes = {"agent": TRACE_ERROR_AGENT_KEYS, "user": USER_ATTRS, "intrinsic": ["trip_id"]}
660669

661670

671+
@FAILING_ON_WINDOWS
662672
@validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
663673
@override_application_settings(_override_settings)
664674
def test_transaction_trace_deprecated_capture_params_false(normal_application):
@@ -718,6 +728,7 @@ def test_error_in_transaction_exclude_intrinsic(normal_application):
718728
_expected_attributes = {"agent": TRACE_ERROR_AGENT_KEYS, "user": USER_ATTRS, "intrinsic": ["trip_id"]}
719729

720730

731+
@FAILING_ON_WINDOWS
721732
@validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
722733
@override_application_settings(_override_settings)
723734
def test_transaction_trace_exclude_intrinsic(normal_application):
@@ -774,6 +785,7 @@ def test_error_in_transaction_attributes_disabled(normal_application):
774785
_override_settings = {"transaction_tracer.attributes.enabled": False}
775786

776787

788+
@FAILING_ON_WINDOWS
777789
@validate_transaction_trace_attributes(_expected_attributes, _expected_absent_attributes)
778790
@override_application_settings(_override_settings)
779791
def test_transaction_trace_attributes_disabled(normal_application):
@@ -831,6 +843,7 @@ def test_error_in_transaction_error_param_excluded(normal_application):
831843
_expected_attributes = {"agent": TRANS_EVENT_AGENT_KEYS, "user": USER_ATTRS, "intrinsic": []}
832844

833845

846+
@FAILING_ON_WINDOWS
834847
@validate_transaction_trace_attributes(_expected_attributes)
835848
@validate_transaction_event_attributes(_expected_attributes)
836849
@override_application_settings(_override_settings)

tests/agent_features/test_collector_payloads.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
import pytest
1616
import webtest
17+
from conftest import FAILING_ON_WINDOWS
1718
from testing_support.fixtures import override_application_settings
1819
from testing_support.sample_applications import simple_app, simple_custom_event_app, simple_exceptional_app
1920
from testing_support.validators.validate_custom_event_collector_json import validate_custom_event_collector_json
@@ -46,11 +47,13 @@ def test_error_event_json():
4647
pass
4748

4849

50+
@FAILING_ON_WINDOWS
4951
@validate_tt_collector_json()
5052
def test_transaction_trace_json():
5153
normal_application.get("/")
5254

5355

56+
@FAILING_ON_WINDOWS
5457
@validate_tt_collector_json(exclude_request_uri=True)
5558
@override_application_settings({"attributes.exclude": {"request.uri"}})
5659
def test_transaction_trace_json_no_request_uri():

tests/agent_features/test_coroutine_trace.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import time
2020

2121
import pytest
22+
from conftest import FAILING_ON_WINDOWS
2223
from testing_support.fixtures import capture_transaction_metrics, validate_tt_parenting
2324
from testing_support.validators.validate_transaction_errors import validate_transaction_errors
2425
from testing_support.validators.validate_transaction_metrics import validate_transaction_metrics
@@ -75,6 +76,7 @@ def _test():
7576
assert full_metrics[metric_key].total_call_time >= 0.2
7677

7778

79+
@FAILING_ON_WINDOWS
7880
@validate_tt_parenting(("TransactionNode", [("FunctionNode", [("FunctionNode", []), ("FunctionNode", [])])]))
7981
@validate_transaction_metrics(
8082
"test_coroutine_siblings",
@@ -246,6 +248,7 @@ def coro():
246248
gen.close()
247249

248250

251+
@FAILING_ON_WINDOWS
249252
@validate_tt_parenting(("TransactionNode", [("FunctionNode", [("FunctionNode", [])])]))
250253
@validate_transaction_metrics(
251254
"test_coroutine_parents",

tests/agent_features/test_coroutine_transaction.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
# limitations under the License.
1414

1515
import asyncio
16-
import sys
1716

1817
import pytest
18+
from conftest import FAILING_ON_WINDOWS
1919
from testing_support.fixtures import capture_transaction_metrics, override_generic_settings
2020
from testing_support.validators.validate_transaction_errors import validate_transaction_errors
2121

@@ -91,6 +91,7 @@ async def task():
9191
test_matrix.append(native_coroutine_test)
9292

9393

94+
@FAILING_ON_WINDOWS
9495
@pytest.mark.parametrize("num_coroutines", (2,))
9596
@pytest.mark.parametrize("create_test_task", test_matrix)
9697
@pytest.mark.parametrize(

tests/agent_features/test_error_events.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import time
1717

1818
import webtest
19+
from conftest import FAILING_ON_WINDOWS
1920
from testing_support.fixtures import (
2021
cat_enabled,
2122
make_cross_agent_headers,
@@ -74,6 +75,7 @@ def test_transaction_error_event_no_extra_attributes():
7475
}
7576

7677

78+
@FAILING_ON_WINDOWS
7779
@validate_error_event_sample_data(required_attrs=_intrinsic_attributes, required_user_attrs=True)
7880
def test_transaction_error_event_lotsa_attributes():
7981
test_environ = {
@@ -97,6 +99,7 @@ def test_transaction_error_event_lotsa_attributes():
9799
}
98100

99101

102+
@FAILING_ON_WINDOWS
100103
@validate_error_event_sample_data(required_attrs=_intrinsic_attributes, required_user_attrs=True)
101104
def test_transaction_error_background_task():
102105
test_environ = {"err_message": ERR_MESSAGE, "external": "2", "db": "2", "newrelic.set_background_task": True}

tests/agent_features/test_function_trace.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
import time
1616

17+
from conftest import FAILING_ON_WINDOWS
1718
from testing_support.fixtures import validate_tt_parenting
1819
from testing_support.validators.validate_transaction_metrics import validate_transaction_metrics
1920

@@ -88,6 +89,7 @@ def test_function_trace_leading_slash_on_group():
8889
)
8990

9091

92+
@FAILING_ON_WINDOWS
9193
@validate_transaction_metrics(
9294
"test_function_trace:test_async_trace_overlapping_children",
9395
scoped_metrics=_test_async_trace_overlapping_children_scoped_metrics,

tests/agent_features/test_high_security_mode.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import pytest
1919
import webtest
20+
from conftest import FAILING_ON_WINDOWS
2021
from testing_support.fixtures import (
2122
override_application_settings,
2223
override_generic_settings,
@@ -705,6 +706,7 @@ def test_http_referrer_url_is_sanitized_in_hsm():
705706
target_application.get("/", extra_environ=environ)
706707

707708

709+
@FAILING_ON_WINDOWS
708710
@pytest.mark.parametrize("hsm_enabled", [True, False])
709711
def test_function_trace_params_dropped_in_hsm(hsm_enabled):
710712
@background_task()
@@ -722,6 +724,7 @@ def _test():
722724
_test()
723725

724726

727+
@FAILING_ON_WINDOWS
725728
@pytest.mark.parametrize("hsm_enabled", [True, False])
726729
def test_message_trace_params_dropped_in_hsm(hsm_enabled):
727730
@background_task()

0 commit comments

Comments
 (0)