Fix Langchain Tests (#1287)

TimPansino · mergify[bot] · web-flow · commit 415dc73ccdad · 2025-01-17T16:11:44.000-08:00
* Fix issue with document ID changing content of request

* Add temperature explicitly as an argument to openai client

---------

Co-authored-by: mergify[bot] &lt;37929162+mergify[bot]@users.noreply.github.com&gt;
diff --git a/tests/mlmodel_langchain/conftest.py b/tests/mlmodel_langchain/conftest.py
@@ -73,6 +73,7 @@ def openai_clients(openai_version, MockExternalOpenAIServer):  # noqa: F811
             chat = ChatOpenAI(
                 base_url=f"http://localhost:{server.port}",
                 api_key="NOT-A-REAL-SECRET",
+                temperature=0.7,
             )
             embeddings = OpenAIEmbeddings(
                 openai_api_key="NOT-A-REAL-SECRET", openai_api_base=f"http://localhost:{server.port}"
diff --git a/tests/mlmodel_langchain/test_chain.py b/tests/mlmodel_langchain/test_chain.py
@@ -525,7 +525,7 @@
             "vendor": "langchain",
             "ingest_source": "Python",
             "virtual_llm": True,
-            "content": "{'input': 'math', 'context': [Document(metadata={}, page_content='What is 2 + 4?')]}",
+            "content": "{'input': 'math', 'context': [Document(id='1234', metadata={}, page_content='What is 2 + 4?')]}",
         },
     ],
     [
@@ -557,7 +557,7 @@
             "ingest_source": "Python",
             "is_response": True,
             "virtual_llm": True,
-            "content": "{'input': 'math', 'context': [Document(metadata={}, page_content='What is 2 + 4?')], 'answer': '```html\\n<!DOCTYPE html>\\n<html>\\n<head>\\n  <title>Math Quiz</title>\\n</head>\\n<body>\\n  <h2>Math Quiz Questions</h2>\\n  <ol>\\n    <li>What is the result of 5 + 3?</li>\\n      <ul>\\n        <li>A) 7</li>\\n        <li>B) 8</li>\\n        <li>C) 9</li>\\n        <li>D) 10</li>\\n      </ul>\\n    <li>What is the product of 6 x 7?</li>\\n      <ul>\\n        <li>A) 36</li>\\n        <li>B) 42</li>\\n        <li>C) 48</li>\\n        <li>D) 56</li>\\n      </ul>\\n    <li>What is the square root of 64?</li>\\n      <ul>\\n        <li>A) 6</li>\\n        <li>B) 7</li>\\n        <li>C) 8</li>\\n        <li>D) 9</li>\\n      </ul>\\n    <li>What is the result of 12 / 4?</li>\\n      <ul>\\n        <li>A) 2</li>\\n        <li>B) 3</li>\\n        <li>C) 4</li>\\n        <li>D) 5</li>\\n      </ul>\\n    <li>What is the sum of 15 + 9?</li>\\n      <ul>\\n        <li>A) 22</li>\\n        <li>B) 23</li>\\n        <li>C) 24</li>\\n        <li>D) 25</li>\\n      </ul>\\n  </ol>\\n</body>\\n</html>\\n```'}",
+            "content": "{'input': 'math', 'context': [Document(id='1234', metadata={}, page_content='What is 2 + 4?')], 'answer': '```html\\n<!DOCTYPE html>\\n<html>\\n<head>\\n  <title>Math Quiz</title>\\n</head>\\n<body>\\n  <h2>Math Quiz Questions</h2>\\n  <ol>\\n    <li>What is the result of 5 + 3?</li>\\n      <ul>\\n        <li>A) 7</li>\\n        <li>B) 8</li>\\n        <li>C) 9</li>\\n        <li>D) 10</li>\\n      </ul>\\n    <li>What is the product of 6 x 7?</li>\\n      <ul>\\n        <li>A) 36</li>\\n        <li>B) 42</li>\\n        <li>C) 48</li>\\n        <li>D) 56</li>\\n      </ul>\\n    <li>What is the square root of 64?</li>\\n      <ul>\\n        <li>A) 6</li>\\n        <li>B) 7</li>\\n        <li>C) 8</li>\\n        <li>D) 9</li>\\n      </ul>\\n    <li>What is the result of 12 / 4?</li>\\n      <ul>\\n        <li>A) 2</li>\\n        <li>B) 3</li>\\n        <li>C) 4</li>\\n        <li>D) 5</li>\\n      </ul>\\n    <li>What is the sum of 15 + 9?</li>\\n      <ul>\\n        <li>A) 22</li>\\n        <li>B) 23</li>\\n        <li>C) 24</li>\\n        <li>D) 25</li>\\n      </ul>\\n  </ol>\\n</body>\\n</html>\\n```'}",
         },
     ],
 ]
@@ -1814,7 +1814,7 @@ def _test():
 @background_task()
 def test_retrieval_chains(set_trace_info, retrieval_chain_prompt, embedding_openai_client, chat_openai_client):
     set_trace_info()
-    documents = [langchain_core.documents.Document(page_content="What is 2 + 4?")]
+    documents = [langchain_core.documents.Document(id="1234", page_content="What is 2 + 4?")]
     vectordb = FAISS.from_documents(documents=documents, embedding=embedding_openai_client)
     retriever = vectordb.as_retriever()
     question_answer_chain = create_stuff_documents_chain(

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,7 @@ def openai_clients(openai_version, MockExternalOpenAIServer): # noqa: F811`
`73`	`73`	`chat = ChatOpenAI(`
`74`	`74`	`base_url=f"http://localhost:{server.port}",`
`75`	`75`	`api_key="NOT-A-REAL-SECRET",`
	`76`	`+ temperature=0.7,`
`76`	`77`	`)`
`77`	`78`	`embeddings = OpenAIEmbeddings(`
`78`	`79`	`openai_api_key="NOT-A-REAL-SECRET", openai_api_base=f"http://localhost:{server.port}"`