Fix RUF015 unnecessary-iterable-allocation-for-first-element

Author: TimPansino

newrelic/hooks/application_gearman.py

@@ -66,7 +66,7 @@ def _bind_params(submitted_connections, *args, **kwargs):
     if not submitted_connections:
         return wrapped(*args, **kwargs)
 
-    first_connection = list(submitted_connections)[0]
+    first_connection = next(iter(submitted_connections))
 
     url = f"gearman://{first_connection.gearman_host}:{first_connection.gearman_port}"
 

newrelic/hooks/framework_graphql.py

@@ -196,7 +196,7 @@ def traverse_deepest_unique_path(fields, fragments):
 
             # list(fragments.values())[0] 's index is OK because the previous line
             # ensures that there is only one field in the list
-            full_fragment_selection_set = list(fragments.values())[0].selection_set.selections
+            full_fragment_selection_set = next(iter(fragments.values())).selection_set.selections
             fragment_selection_set = filter_ignored_fields(full_fragment_selection_set)
 
             if len(fragment_selection_set) != 1:

pyproject.toml

@@ -137,8 +137,11 @@ ignore = [
     "S",  # flake8-bandit (security checks are not necessary in tests)
     "F401",  # unused-import
     "F811",  # redefined-while-unused (pytest fixtures trigger this)
+    "RUF012",  # mutable-class-default
+    "RUF015",  # unnecessary-iterable-allocation-for-first-element (more readable in tests)
     "E731",  # lambda-assignment (acceptable in tests)
     "RUF012",  # mutable-class-default
+    "RUF015",  # unnecessary-iterable-allocation-for-first-element (more readable in tests)
     "PLR2004",  # magic-value-comparison (comparing to constant values)
     "ASYNC251",  # blocking-sleep-in-async-function (acceptable in tests)
     "B904",  # raise-without-from-inside-except (not necessary in tests)

tests/agent_features/test_log_events.py

@@ -56,6 +56,11 @@ def set_trace_ids():
         trace.guid = "abcdefgh"
 
 
+def active_session():
+    txn = current_transaction()
+    return list(txn.application._agent._applications.values())[0]._active_session
+
+
 def exercise_record_log_event():
     set_trace_ids()
 
@@ -407,9 +412,7 @@ def test():
 @override_application_settings({"labels": TEST_LABELS, "application_logging.forwarding.labels.enabled": True})
 @background_task()
 def test_label_forwarding_enabled():
-    txn = current_transaction()
-    session = list(txn.application._agent._applications.values())[0]._active_session
-
+    session = active_session()
     common = session.get_log_events_common_block()
     # Excluded label should not appear, and other labels should be prefixed with 'tag.'
     assert common == {"tags.testlabel1": "A", "tags.testlabel2": "B", "tags.testlabelexclude": "C"}
@@ -424,9 +427,7 @@ def test_label_forwarding_enabled():
 )
 @background_task()
 def test_label_forwarding_enabled_exclude():
-    txn = current_transaction()
-    session = list(txn.application._agent._applications.values())[0]._active_session
-
+    session = active_session()
     common = session.get_log_events_common_block()
     # Excluded label should not appear, and other labels should be prefixed with 'tags.'
     assert common == {"tags.testlabel1": "A", "tags.testlabel2": "B"}
@@ -435,9 +436,7 @@ def test_label_forwarding_enabled_exclude():
 @override_application_settings({"labels": TEST_LABELS, "application_logging.forwarding.labels.enabled": False})
 @background_task()
 def test_label_forwarding_disabled():
-    txn = current_transaction()
-    session = list(txn.application._agent._applications.values())[0]._active_session
-
+    session = active_session()
     common = session.get_log_events_common_block()
     # No labels should appear
     assert common == {}
@@ -453,9 +452,7 @@ def test_label_forwarding_disabled():
 )
 @background_task()
 def test_global_custom_attribute_forwarding_enabled():
-    txn = current_transaction()
-    session = list(txn.application._agent._applications.values())[0]._active_session
-
+    session = active_session()
     common = session.get_log_events_common_block()
     # Both attrs should appear
     assert common == {"custom_attr_1": "value 1", "custom_attr_2": "value 2"}
@@ -464,9 +461,7 @@ def test_global_custom_attribute_forwarding_enabled():
 @override_application_settings({"application_logging.forwarding.custom_attributes": [("custom_attr_1", "a" * 256)]})
 @background_task()
 def test_global_custom_attribute_forwarding_truncation():
-    txn = current_transaction()
-    session = list(txn.application._agent._applications.values())[0]._active_session
-
+    session = active_session()
     common = session.get_log_events_common_block()
     # Attribute value should be truncated to the max user attribute length
     assert common == {"custom_attr_1": "a" * 255}
@@ -477,9 +472,7 @@ def test_global_custom_attribute_forwarding_truncation():
 )
 @background_task()
 def test_global_custom_attribute_forwarding_max_num_attrs():
-    txn = current_transaction()
-    session = list(txn.application._agent._applications.values())[0]._active_session
-
+    session = active_session()
     common = session.get_log_events_common_block()
     # Should be truncated to the max number of user attributes
     assert common == {f"custom_attr_{i + 1}": "value" for i in range(128)}