Apply suggestions from code review

Co-authored-by: Hannah Stepanek <[email protected]>

Author: TimPansino

tests/datastore_firestore/test_async_query.py

@@ -179,8 +179,8 @@ async def _mock_partition_query():
 def exercise_async_collection_group(async_client, async_collection):
     async def _exercise_async_collection_group():
         async_collection_group = async_client.collection_group(async_collection.id)
-        assert len(await async_collection_group.get()) >= 1
-        assert len([d async for d in async_collection_group.stream()]) >= 1
+        assert await async_collection_group.get()
+        assert [d async for d in async_collection_group.stream()]
 
         partitions = [p async for p in async_collection_group.get_partitions(1)]
         assert len(partitions) == 2

tests/datastore_firestore/test_client.py

@@ -29,7 +29,7 @@ def sample_data(collection):
 @pytest.fixture()
 def exercise_client(client, sample_data):
     def _exercise_client():
-        assert len([_ for _ in client.collections()]) >= 1
+        assert [_ for _ in client.collections()]
         doc = [_ for _ in client.get_all([sample_data])][0]
         assert doc.to_dict()["x"] == 1
 

tests/datastore_firestore/test_query.py

@@ -172,8 +172,8 @@ def mock_partition_query(*args, **kwargs):
 def exercise_collection_group(client, collection, patch_partition_queries):
     def _exercise_collection_group():
         collection_group = client.collection_group(collection.id)
-        assert len(collection_group.get())
-        assert len([d for d in collection_group.stream()]) >= 1
+        assert collection_group.get()
+        assert [d for d in collection_group.stream()]
 
         partitions = [p for p in collection_group.get_partitions(1)]
         assert len(partitions) == 2