Update oracledb to test older major versions

Author: TimPansino

newrelic/hooks/database_oracledb.py

@@ -136,5 +136,8 @@ def instrument_oracledb(module):
         module, database_product="Oracle", quoting_style="single+oracle", instance_info=instance_info
     )
 
-    wrap_object(module, "connect", ConnectionFactory, (module,))
-    wrap_object(module, "connect_async", AsyncConnectionFactory, (module,))
+    if hasattr(module, "connect"):
+        wrap_object(module, "connect", ConnectionFactory, (module,))
+
+    if hasattr(module, "connect_async"):
+        wrap_object(module, "connect_async", AsyncConnectionFactory, (module,))

tests/datastore_oracledb/test_async_connection.py

@@ -13,12 +13,18 @@
 # limitations under the License.
 
 import oracledb
+import pytest
 from testing_support.db_settings import oracledb_settings
 from testing_support.util import instance_hostname
 from testing_support.validators.validate_database_trace_inputs import validate_database_trace_inputs
 from testing_support.validators.validate_transaction_metrics import validate_transaction_metrics
 
 from newrelic.api.background_task import background_task
+from newrelic.common.package_version_utils import get_package_version_tuple
+
+ORACLEDB_VERSION = get_package_version_tuple("oracledb")
+if ORACLEDB_VERSION < (2,):
+    pytest.skip(reason="OracleDB version does not contain async APIs.", allow_module_level=True)
 
 DB_SETTINGS = oracledb_settings()[0]
 TABLE_NAME = DB_SETTINGS["table_name"]

tox.ini

@@ -67,7 +67,9 @@ envlist =
     mysql-datastore_mysql-mysqllatest-{py37,py38,py39,py310,py311,py312,py313},
     mysql-datastore_mysqldb-{py38,py39,py310,py311,py312,py313},
     mysql-datastore_pymysql-{py37,py38,py39,py310,py311,py312,py313,pypy310},
-    oracledb-datastore_oracledb-{py39,py310,py311,py312,py313},
+    oracledb-datastore_oracledb-{py39,py310,py311,py312,py313}-oracledblatest,
+    oracledb-datastore_oracledb-{py39,py313}-oracledb02,
+    oracledb-datastore_oracledb-{py39,py312}-oracledb01,
     nginx-external_httpx-{py37,py38,py39,py310,py311,py312,py313},
     postgres16-datastore_asyncpg-{py37,py38,py39,py310,py311,py312,py313},
     postgres16-datastore_psycopg-{py38,py39,py310,py311,py312,py313,pypy310}-psycopglatest,
@@ -280,7 +282,9 @@ deps =
     datastore_mysql: protobuf<4
     # mysqlclient is the Python 3 replacement for MySQLdb
     datastore_mysqldb: mysqlclient
-    datastore_oracledb: oracledb
+    datastore_oracledb-oracledblatest: oracledb
+    datastore_oracledb-oracledb02: oracledb<3
+    datastore_oracledb-oracledb01: oracledb<2
     datastore_postgresql: py-postgresql
     datastore_psycopg-psycopglatest: psycopg[binary]>=3
     datastore_psycopg-psycopg_purepython0301: psycopg<3.2