Skip to content

Commit ba61356

Browse files
committed
Double adaptive sampling when core tracing is on
1 parent bdb3a23 commit ba61356

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

newrelic/core/application.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,11 @@ def connect_to_data_collector(self, activate_agent):
507507
sampling_target_period = 60.0
508508
else:
509509
sampling_target_period = configuration.sampling_target_period_in_seconds
510-
self.adaptive_sampler = AdaptiveSampler(configuration.sampling_target, sampling_target_period)
510+
sampling_target = configuration.sampling_target
511+
# If CT is enabled double the transaction reservoir size.
512+
if configuration.core_tracing.enabled:
513+
sampling_target = configuration.sampling_target*2
514+
self.adaptive_sampler = AdaptiveSampler(sampling_target, sampling_target_period)
511515

512516
active_session.connect_span_stream(self._stats_engine.span_stream, self.record_custom_metric)
513517

@@ -1367,6 +1371,7 @@ def harvest(self, shutdown=False, flexible=False):
13671371

13681372
internal_count_metric("Supportability/InfiniteTracing/Span/Seen", spans_seen)
13691373
internal_count_metric("Supportability/InfiniteTracing/Span/Sent", spans_sent)
1374+
print(f"spans sent: {spans_sent}")
13701375
internal_count_metric("Supportability/InfiniteTracing/Bytes/Seen", _bytes)
13711376
internal_count_metric("Supportability/CoreTracing/TotalTime", ct_processing_time*1000) # Time in ms.
13721377
else:
@@ -1385,6 +1390,7 @@ def harvest(self, shutdown=False, flexible=False):
13851390
spans_sampled = spans.num_samples
13861391
internal_count_metric("Supportability/SpanEvent/TotalEventsSeen", spans_seen)
13871392
internal_count_metric("Supportability/SpanEvent/TotalEventsSent", spans_sampled)
1393+
print(f"spans sent: {spans_sampled}")
13881394
internal_count_metric("Supportability/DistributedTracing/Bytes/Seen", spans.bytes)
13891395
internal_count_metric("Supportability/SpanEvent/TotalCoreTracingTime", spans.ct_processing_time*1000) # Time in ms.
13901396

0 commit comments

Comments
 (0)