fix gc settings attribute error. (#480)

* fix gc settings attribute error.

Co-authored-by: Elise Spain <[email protected]>
Co-authored-by: Jessica Shortz <jshortz.newrelic.com>
Co-authored-by: Uma Annamalai <[email protected]>

* [Mega-Linter] Apply linters fixes

Co-authored-by: Elise Spain <[email protected]>
Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: hannahramadan <[email protected]>

Author: 3 people

newrelic/core/config.py

@@ -116,7 +116,7 @@ class AttributesSettings(Settings):
 
 
 class GCRuntimeMetricsSettings(Settings):
-    pass
+    enabled = False
 
 
 class ThreadProfilerSettings(Settings):

newrelic/samplers/gc_data.py

@@ -34,10 +34,10 @@ def __init__(self, settings, environ):
 
     @property
     def enabled(self):
-        if platform.python_implementation() == "PyPy":
+        settings = global_settings()
+        if platform.python_implementation() == "PyPy" or not settings:
             return False
         else:
-            settings = global_settings()
             return settings.gc_runtime_metrics.enabled
 
     @property
@@ -55,18 +55,12 @@ def record_gc(self, phase, info):
             self.start_time = time.time()
         elif phase == "stop":
             total_time = time.time() - self.start_time
-            self.gc_time_metrics.record_custom_metric(
-                "GC/time/%d/all" % self.pid, total_time
-            )
+            self.gc_time_metrics.record_custom_metric("GC/time/%d/all" % self.pid, total_time)
             for gen in range(0, 3):
                 if gen <= current_generation:
-                    self.gc_time_metrics.record_custom_metric(
-                        "GC/time/%d/%d" % (self.pid, gen), total_time
-                    )
+                    self.gc_time_metrics.record_custom_metric("GC/time/%d/%d" % (self.pid, gen), total_time)
                 else:
-                    self.gc_time_metrics.record_custom_metric(
-                        "GC/time/%d/%d" % (self.pid, gen), 0
-                    )
+                    self.gc_time_metrics.record_custom_metric("GC/time/%d/%d" % (self.pid, gen), 0)
 
     def start(self):
         if hasattr(gc, "callbacks"):
@@ -100,9 +94,7 @@ def __call__(self):
         if hasattr(gc, "get_objects"):
             object_types = map(type, gc.get_objects())
             if self.top_object_count_limit > 0:
-                highest_types = Counter(object_types).most_common(
-                    self.top_object_count_limit
-                )
+                highest_types = Counter(object_types).most_common(self.top_object_count_limit)
                 for obj_type, count in highest_types:
                     yield (
                         "GC/objects/%d/type/%s" % (self.pid, callable_name(obj_type)),