Feature increased custom event limit (#674)

* Update reservoir size for custom events.

* [Mega-Linter] Apply linters fixes

* Increase custom event limit. (#666)

* Remove duplicated CUSTOM_EVENT_RESERVOIR_SIZE

Co-authored-by: Tim Pansino <[email protected]>
Co-authored-by: TimPansino <[email protected]>
Co-authored-by: Timothy Pansino <[email protected]>
Co-authored-by: Uma Annamalai <[email protected]>

Author: 3 people

newrelic/api/transaction.py

@@ -59,7 +59,7 @@
     DST_NONE,
     DST_TRANSACTION_TRACER,
 )
-from newrelic.core.config import DEFAULT_RESERVOIR_SIZE, LOG_EVENT_RESERVOIR_SIZE
+from newrelic.core.config import CUSTOM_EVENT_RESERVOIR_SIZE, LOG_EVENT_RESERVOIR_SIZE
 from newrelic.core.custom_event import create_custom_event
 from newrelic.core.log_event_node import LogEventNode
 from newrelic.core.stack_trace import exception_stack
@@ -333,7 +333,7 @@ def __init__(self, application, enabled=None, source=None):
                 capacity=self._settings.event_harvest_config.harvest_limits.log_event_data
             )
         else:
-            self._custom_events = SampledDataSet(capacity=DEFAULT_RESERVOIR_SIZE)
+            self._custom_events = SampledDataSet(capacity=CUSTOM_EVENT_RESERVOIR_SIZE)
             self._log_events = SampledDataSet(capacity=LOG_EVENT_RESERVOIR_SIZE)
 
     def __del__(self):

newrelic/core/config.py

@@ -52,6 +52,7 @@
 # reservoir. Error Events have a different default size.
 
 DEFAULT_RESERVOIR_SIZE = 1200
+CUSTOM_EVENT_RESERVOIR_SIZE = 3600
 ERROR_EVENT_RESERVOIR_SIZE = 100
 SPAN_EVENT_RESERVOIR_SIZE = 2000
 LOG_EVENT_RESERVOIR_SIZE = 10000
@@ -738,7 +739,7 @@ def default_host(license_key):
 )
 
 _settings.event_harvest_config.harvest_limits.custom_event_data = _environ_as_int(
-    "NEW_RELIC_CUSTOM_INSIGHTS_EVENTS_MAX_SAMPLES_STORED", DEFAULT_RESERVOIR_SIZE
+    "NEW_RELIC_CUSTOM_INSIGHTS_EVENTS_MAX_SAMPLES_STORED", CUSTOM_EVENT_RESERVOIR_SIZE
 )
 
 _settings.event_harvest_config.harvest_limits.span_event_data = _environ_as_int(

tests/agent_features/test_configuration.py

@@ -438,12 +438,12 @@ def test_delete_setting_parent():
         TSetting("event_harvest_config.harvest_limits.error_event_data", 100, 100),
     ),
     (
-        TSetting("custom_insights_events.max_samples_stored", 1200, 1200),
-        TSetting("event_harvest_config.harvest_limits.custom_event_data", 9999, 1200),
+        TSetting("custom_insights_events.max_samples_stored", 3600, 3600),
+        TSetting("event_harvest_config.harvest_limits.custom_event_data", 9999, 3600),
     ),
     (
-        TSetting("custom_insights_events.max_samples_stored", 9999, 1200),
-        TSetting("event_harvest_config.harvest_limits.custom_event_data", 1200, 1200),
+        TSetting("custom_insights_events.max_samples_stored", 9999, 3600),
+        TSetting("event_harvest_config.harvest_limits.custom_event_data", 3600, 3600),
     ),
     (
         TSetting("application_logging.forwarding.max_samples_stored", 10000, 10000),