Enable pyflakes (#1354)

* Enable Pyflakes

* Fix F901 raise-not-implemented

* Fix missing early exit in psycopg2 wrappers

* Drop unused vars from kombu instrumentation

* Remove multiple unused variables from openai instrumentation

* Fix F841 unused-variable

* Fix F401 unused-import

* Fix F821 undefined-name

* Fix F541 f-string-missing-placeholders

* Remove Py37+ test gating on async generators

* Fix F403 undefined-local-with-import-star

* Fix F811 redefined-while-unused

* Fix naming error in async generator trace tests

* Fix monkeypatch setenv with incorrect type

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Author: TimPansino

newrelic/admin/record_deploy.py

@@ -16,7 +16,7 @@
 import pwd
 
 from newrelic.admin import command, usage
-from newrelic.common import agent_http, certs, encoding_utils
+from newrelic.common import agent_http, encoding_utils
 from newrelic.config import initialize
 from newrelic.core.config import global_settings
 

newrelic/admin/run_python.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from newrelic.admin import command, usage
+from newrelic.admin import command
 
 
 @command(
@@ -62,7 +62,6 @@ def log_message(text, *args):
             log_message("%s = %r", name, os.environ.get(name))
 
     from newrelic import __file__ as root_directory
-    from newrelic import version
 
     root_directory = os.path.dirname(root_directory)
     boot_directory = os.path.join(root_directory, "bootstrap")

newrelic/api/in_function.py

@@ -14,4 +14,4 @@
 
 # Use of these from this module will be deprecated.
 
-from newrelic.common.object_wrapper import InFunctionWrapper, in_function, wrap_in_function
+from newrelic.common.object_wrapper import InFunctionWrapper, in_function, wrap_in_function  # noqa: F401

newrelic/api/object_wrapper.py

@@ -12,13 +12,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import sys
-
 # These have been moved. They are retained here until all references to
 # them are moved at which point will mark as deprecated to ensure users
 # weren't using them directly.
-from newrelic.common.object_names import callable_name
-from newrelic.common.object_wrapper import ObjectWrapper, wrap_object
+from newrelic.common.object_names import callable_name  # noqa: F401
+from newrelic.common.object_wrapper import ObjectWrapper, wrap_object  # noqa: F401
 
 # From Python 3.X. In older Python versions it fails if attributes do
 # not exist and don't maintain a __wrapped__ attribute.

newrelic/api/out_function.py

@@ -14,4 +14,4 @@
 
 # Use of these from this module will be deprecated.
 
-from newrelic.common.object_wrapper import OutFunctionWrapper, out_function, wrap_out_function
+from newrelic.common.object_wrapper import OutFunctionWrapper, out_function, wrap_out_function  # noqa: F401

newrelic/api/post_function.py

@@ -14,4 +14,4 @@
 
 # Use of these from this module will be deprecated.
 
-from newrelic.common.object_wrapper import PostFunctionWrapper, post_function, wrap_post_function
+from newrelic.common.object_wrapper import PostFunctionWrapper, post_function, wrap_post_function  # noqa: F401

newrelic/api/pre_function.py

@@ -14,4 +14,4 @@
 
 # Use of these from this module will be deprecated.
 
-from newrelic.common.object_wrapper import PreFunctionWrapper, pre_function, wrap_pre_function
+from newrelic.common.object_wrapper import PreFunctionWrapper, pre_function, wrap_pre_function  # noqa: F401

newrelic/common/async_wrapper.py

@@ -64,7 +64,7 @@ async def wrapper(*args, **kwargs):
                 while True:
                     try:
                         sent = yield yielded
-                    except GeneratorExit as e:
+                    except GeneratorExit:
                         await g.aclose()
                         raise
                     except BaseException as e:

newrelic/common/object_names.py

@@ -18,7 +18,6 @@
 import functools
 import inspect
 import sys
-import types
 
 # Object model terminology for quick reference.
 #

newrelic/console.py

@@ -366,8 +366,6 @@ def do_interpreter(self):
         interactive Python interpreter. Invoke 'exit()' or 'quit()' to
         escape the interpreter session."""
 
-        enabled = False
-
         _settings = global_settings()
 
         if not _settings.console.allow_interpreter_cmd: