Skip to content

Commit e024468

Browse files
committed
Move inifinte tracing override to server side config
1 parent 923ad1d commit e024468

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

newrelic/core/config.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1357,6 +1357,17 @@ def apply_server_side_settings(server_side_config=None, settings=_settings):
13571357
min(settings_snapshot.custom_insights_events.max_attribute_value, 4095),
13581358
)
13591359

1360+
# Partial granularity tracing is not available in infinite tracing mode.
1361+
if settings_snapshot.infinite_tracing.enabled and settings_snapshot.distributed_tracing.sampler.partial_granularity.enabled:
1362+
_logger.warning(
1363+
"Improper configuration. Infinite tracing cannot be enabled at the same time as partial granularity tracing. Setting distributed_tracing.sampler.partial_granularity.enabled=False."
1364+
)
1365+
apply_config_setting(
1366+
settings_snapshot,
1367+
"distributed_tracing.sampler.partial_granularity.enabled",
1368+
False,
1369+
)
1370+
13601371
# This will be removed at some future point
13611372
# Special case for account_id which will be sent instead of
13621373
# cross_process_id in the future
@@ -1396,20 +1407,9 @@ def finalize_application_settings(server_side_config=None, settings=_settings):
13961407

13971408
application_settings.attribute_filter = AttributeFilter(flatten_settings(application_settings))
13981409

1399-
simplify_distributed_tracing_sampler_granularity_settings(application_settings)
1400-
14011410
return application_settings
14021411

14031412

1404-
def simplify_distributed_tracing_sampler_granularity_settings(settings):
1405-
# Partial granularity tracing is not available in infinite tracing mode.
1406-
if settings.infinite_tracing.enabled and settings.distributed_tracing.sampler.partial_granularity.enabled:
1407-
_logger.warning(
1408-
"Improper configuration. Infinite tracing cannot be enabled at the same time as partial granularity tracing. Setting distributed_tracing.sampler.partial_granularity.enabled=False."
1409-
)
1410-
settings.distributed_tracing.sampler.partial_granularity.enabled = False
1411-
1412-
14131413
def _remove_ignored_configs(server_settings):
14141414
if not server_settings.get("agent_config"):
14151415
return server_settings

0 commit comments

Comments
 (0)