Add logic for dropping inprocess spans

Author: hmstepanek

newrelic/core/attribute.py

@@ -98,6 +98,23 @@
     "server.address",
 }
 
+SPAN_ENTITY_RELATIONSHIP_ATTRIBUTES = {
+    "cloud.account.id",
+    "cloud.platform",
+    "cloud.region",
+    "cloud.resource_id",
+    "db.instance",
+    "db.system",
+    "http.url",
+    "messaging.destination.name",
+    "messaging.system",
+    "peer.hostname",
+    "server.address",
+    "server.port",
+    "span.kind",
+}
+
+
 MAX_NUM_USER_ATTRIBUTES = 128
 MAX_ATTRIBUTE_LENGTH = 255
 MAX_NUM_ML_USER_ATTRIBUTES = 64

newrelic/core/external_node.py

@@ -172,6 +172,8 @@ def trace_node(self, stats, root, connections):
     def span_event(self, *args, **kwargs):
         self.agent_attributes["http.url"] = self.http_url
         attrs = super().span_event(*args, **kwargs)
+        if not attrs:
+            return None
         i_attrs = attrs[0]
 
         i_attrs["category"] = "http"

newrelic/core/function_node.py

@@ -116,6 +116,8 @@ def trace_node(self, stats, root, connections):
 
     def span_event(self, *args, **kwargs):
         attrs = super().span_event(*args, **kwargs)
+        if not attrs:
+            return None
         i_attrs = attrs[0]
 
         i_attrs["name"] = f"{self.group}/{self.name}"

newrelic/core/loop_node.py

@@ -81,6 +81,8 @@ def trace_node(self, stats, root, connections):
 
     def span_event(self, *args, **kwargs):
         attrs = super().span_event(*args, **kwargs)
+        if not attrs:
+            return None
         i_attrs = attrs[0]
 
         i_attrs["name"] = f"EventLoop/Wait/{self.name}"

newrelic/core/node_mixin.py

@@ -70,16 +70,38 @@ def span_event(self, settings, base_attrs=None, parent_guid=None, attr_class=dic
         )
 
         # intrinsics, user attrs, agent attrs
+        if settings.core_tracing.drop_inprocess_spans:
+            if not parent_guid:
+                return [i_attrs, u_attrs, a_attrs]
+            set_inprocess_attrs = set(attribute.SPAN_ENTITY_RELATIONSHIP_ATTRIBUTES)
+            set_a_attrs = set(a_attrs)
+            exit_span_attrs_present = set_inprocess_attrs & set_a_attrs
+            if not exit_span_attrs_present:
+                return None
         return [i_attrs, u_attrs, a_attrs]
 
     def span_events(self, settings, base_attrs=None, parent_guid=None, attr_class=dict):
-        yield self.span_event(settings, base_attrs=base_attrs, parent_guid=parent_guid, attr_class=attr_class)
+        if settings.core_tracing.drop_inprocess_spans:
+            span = self.span_event(settings, base_attrs=base_attrs, parent_guid=parent_guid, attr_class=attr_class)
+            parent_id = parent_guid
+            if span:  # span will be None if the span is an inprocess span.
+                yield span
+                parent_id = self.guid
+
+            for child in self.children:
+                for event in child.span_events(  # noqa: UP028
+                    settings, base_attrs=base_attrs, parent_guid=parent_id, attr_class=attr_class
+                ):
+                    if event:
+                        yield event
+        else:
+            yield self.span_event(settings, base_attrs=base_attrs, parent_guid=parent_guid, attr_class=attr_class)
 
-        for child in self.children:
-            for event in child.span_events(  # noqa: UP028
-                settings, base_attrs=base_attrs, parent_guid=self.guid, attr_class=attr_class
-            ):
-                yield event
+            for child in self.children:
+                for event in child.span_events(  # noqa: UP028
+                    settings, base_attrs=base_attrs, parent_guid=self.guid, attr_class=attr_class
+                ):
+                    yield event
 
 
 class DatastoreNodeMixin(GenericNodeMixin):
@@ -141,4 +163,13 @@ def span_event(self, *args, **kwargs):
         except Exception:
             pass
 
+        # intrinsics, user attrs, agent attrs
+        if settings.core_tracing.drop_inprocess_spans:
+            if not parent_guid:
+                return [i_attrs, u_attrs, a_attrs]
+            set_inprocess_attrs = set(attribute.SPAN_ENTITY_RELATIONSHIP_ATTRIBUTES)
+            set_a_attrs = set(a_attrs)
+            exit_span_attrs_present = set_inprocess_attrs & set_a_attrs
+            if not exit_span_attrs_present:
+                return None
         return attrs

newrelic/core/root_node.py

@@ -39,6 +39,8 @@
 class RootNode(_RootNode, GenericNodeMixin):
     def span_event(self, *args, **kwargs):
         span = super().span_event(*args, **kwargs)
+        if not span:
+            return None
         i_attrs = span[0]
         i_attrs["transaction.name"] = self.path
         i_attrs["nr.entryPoint"] = True