Apply suggestions from code review

TimPansino · TimPansino · commit faf850243db0 · 2025-05-23T10:21:13.000-07:00
diff --git a/tests/agent_features/test_logs_in_context.py b/tests/agent_features/test_logs_in_context.py
@@ -241,7 +241,6 @@ def test_newrelic_logger_error_inside_transaction_with_stack_trace(log_buffer_wi
     assert filename.endswith("/test_logs_in_context.py")
     assert isinstance(line_number, int)
     assert isinstance(stack_trace, str)
-    assert stack_trace
     assert stack_trace == expected_stack_trace
 
     expected = {
@@ -330,7 +329,6 @@ def test_newrelic_logger_error_outside_transaction_with_stack_trace(log_buffer_w
     assert filename.endswith("/test_logs_in_context.py")
     assert isinstance(line_number, int)
     assert isinstance(stack_trace, str)
-    assert stack_trace
     assert stack_trace == expected_stack_trace
 
     expected = {
diff --git a/tests/cross_agent/fixtures/rum_loader_insertion_location/no_end_header.html b/tests/cross_agent/fixtures/rum_loader_insertion_location/no_end_header.html
@@ -16,7 +16,9 @@
 -->
 
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
-<head>EXPECTED_RUM_LOADER_LOCATION<body>
-    Cribbed from the Java agent
-  </body>
+  <head>EXPECTED_RUM_LOADER_LOCATION
+    <body>
+      Cribbed from the Java agent
+    </body>
+  <!-- Missing end header tag -->
 </html>
diff --git a/tests/datastore_psycopg/test_obfuscation.py b/tests/datastore_psycopg/test_obfuscation.py
@@ -87,7 +87,6 @@ def any_length_explain_plan(node):
 
     sql_connections = SQLConnections()
     explain_plan = node.explain_plan(sql_connections)
-    assert explain_plan
     assert len(explain_plan) > 0
 
 
diff --git a/tests/datastore_psycopg2/test_obfuscation.py b/tests/datastore_psycopg2/test_obfuscation.py
@@ -95,7 +95,6 @@ def any_length_explain_plan(node):
 
     sql_connections = SQLConnections()
     explain_plan = node.explain_plan(sql_connections)
-    assert explain_plan
     assert len(explain_plan) > 0
 
 
diff --git a/tests/framework_grpc/test_clients.py b/tests/framework_grpc/test_clients.py
@@ -179,7 +179,6 @@ def _test_future_timeout_error():
         request = create_request(streaming_request, count=1, timesout=True)
 
         reply = get_result(service_method_method, request, timeout=0.01)
-        assert reply
         assert reply.code() == grpc.StatusCode.DEADLINE_EXCEEDED
 
     _test_future_timeout_error()
