Camunda Pyzeebe Instrumentation #1385
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
==========================================
- Coverage 81.57% 81.01% -0.56%
==========================================
Files 205 206 +1
Lines 23217 23346 +129
Branches 3670 3697 +27
==========================================
- Hits 18939 18914 -25
- Misses 3055 3168 +113
- Partials 1223 1264 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
umaannamalai
requested changes
May 21, 2025
khpeet
commented
Jun 10, 2025
hmstepanek
requested changes
Aug 27, 2025
newrelic/hooks/external_pyzeebe.py
Outdated
| elif method_name == "deploy_resource": | ||
| resources = list(args) | ||
| if len(resources) == 1 and isinstance(resources[0], (list, tuple)): | ||
| resources = list(resources[0]) |
There was a problem hiding this comment.
For this one-just cast it to a list after the value comes back from the generic call.
There was a problem hiding this comment.
@hmstepanek - do you mean to just remove the if check and simply:
elif method_name == "deploy_resource":
resources = list(args)
if resources:
trace._add_agent_attribute("zeebe.client.resourceCount", len(resources))
if len(resources) == 1:
trace._add_agent_attribute("zeebe.client.resourceFile", str(resources[0]))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Camunda Pyzeebe Module
@worker.task/@router.taskNeed help with writing some tests for this instrumentation though