Add Converse API support. DO NOT MERGE YET #1428
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
==========================================
+ Coverage 81.33% 81.36% +0.02%
==========================================
Files 208 208
Lines 23585 23660 +75
Branches 3719 3728 +9
==========================================
+ Hits 19184 19251 +67
- Misses 3144 3149 +5
- Partials 1257 1260 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmstepanek
changed the title
hmstepanek
requested changes
Aug 1, 2025
| ): | ||
| try: | ||
| bedrock_attrs = {"model": model, "span_id": span_id, "trace_id": trace_id} | ||
| if is_converse: |
There was a problem hiding this comment.
A couple thoughts on the design of this:
I wonder if there's a way you could move this if is_converse block into a request_extractor? Have you explored that at all/do you think that's worth exploring?
OR
Maybe converse should not use this extractor concept at all since it doesn't need to.
hmstepanek
reviewed
Aug 6, 2025
…ewrelic-python-agent into coverse-non-streaming-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the AWS Bedrock
Converseoperation.