Skip to content

Remove CAT #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 118 commits into
base: develop-v12.0.0
Choose a base branch
from
Open

Remove CAT #1489

wants to merge 118 commits into from
+439 −3,636

Conversation

@lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Sep 12, 2025

This PR removes Cross Application Tracing (CAT) from the agent

@lrafeei lrafeei changed the base branch from main to develop-11.0.0 September 12, 2025 02:16
@mergify mergify bot added the merge-conflicts Merge conflicts detected. label Sep 12, 2025
@github-actions
Copy link

github-actions bot commented Sep 12, 2025 •
edited
Loading

✅MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 0.98s
✅ MARKDOWN markdownlint 7 0 0 0 1.33s
✅ PYTHON ruff 941 0 0 0 1.1s
✅ PYTHON ruff-format 941 0 0 0 0.36s
✅ YAML prettier 15 0 0 0 1.44s
✅ YAML v8r 15 0 0 6.39s
✅ YAML yamllint 15 0 0 0.69s

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing Tests failing in CI. label Sep 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 92.18750% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.71%. Comparing base (fcaeb10) to head (f245ebf).

Files with missing lines Patch % Lines
newrelic/hooks/framework_aiohttp.py 81.25% 3 Missing ⚠️
newrelic/hooks/framework_sanic.py 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           develop-v12.0.0    #1489      +/-   ##
===================================================
- Coverage            81.76%   81.71%   -0.05%     
===================================================
  Files                  207      207              
  Lines                23946    23679     -267     
  Branches              3796     3742      -54     
===================================================
- Hits                 19579    19350     -229     
+ Misses                3100     3074      -26     
+ Partials              1267     1255      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot removed the merge-conflicts Merge conflicts detected. label Sep 12, 2025
@lrafeei
Remove cross_application_tracer.enabled setting
61e2b9a
@lrafeei
Remove cat_enabled fixture
e9bab52
@lrafeei
Remove validate_outbound_headers, make_cross_agent_headers
fb1b85e
@lrafeei
Remove path_hash
4df07f3
@lrafeei
Fix tornado tests
e5a0d4e
@lrafeei
Fix aiohttp tests
d145940
@lrafeei
Fix httpx tests
01da681
@lrafeei
Fix pika tests
e3389f3
@lrafeei
Fix sanic tests
a32ca51
@lrafeei
Remove more CAT tests
5b52a78
@lrafeei
Remove nr.guid
931b1c6
@lrafeei
Rename synthetics in CatHeaderMixin
c9e7278
@lrafeei
Remove process_response_headers
3df9e14
@lrafeei
Remove validate_external_node_params
89c9fb5
@lrafeei
Rename CatHeaderMixin to HeaderMixin
23ff187
@lrafeei
Remove _generate_response_headers
566d250
@lrafeei
Remove insert_incoming_headers
521496c
@lrafeei
Remove create_incoming_headers
f7bd2ee
@lrafeei
Remove X-NewRelic-App-Data
5ed7055
@lrafeei
Remove cross_process_id
af451d6
@lrafeei
Remove external_txn_name
1adb307
@lrafeei
Remove referring_transaction_guid
46436eb
@lrafeei
Remove trip_id
855d65e
@lrafeei
Remove convert_to_cat_metadata_value
954177d
@hmstepanek hmstepanek changed the base branch from main to develop-v12.0.0 September 26, 2025 23:30
hmstepanek
hmstepanek reviewed Oct 16, 2025
View reviewed changes
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we forgot to remove synthetics from the stats engine too.

@mergify mergify bot removed the tests-failing Tests failing in CI. label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimPansino TimPansino TimPansino left review comments

@hmstepanek hmstepanek hmstepanek requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@hmstepanek hmstepanek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lrafeei @codecov-commenter @TimPansino @hmstepanek