Skip to content

Commit bc42729

Browse files
committed
Fix organization
1 parent 3321397 commit bc42729

File tree

8 files changed

+18
-7
lines changed

8 files changed

+18
-7
lines changed

lib/subscriber-configs.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
// 'package-name': [ { path: 'subscriberPath', instrumentations: [] }, ... ]
1010
const subscribers = {
1111
...require('./subscribers/amqplib/config'),
12+
...require('./subscribers/aws-sdk/config'),
1213
...require('./subscribers/bluebird/config'),
1314
...require('./subscribers/bunyan/config'),
1415
...require('./subscribers/cassandra-driver/config'),
@@ -33,7 +34,6 @@ const subscribers = {
3334
...require('./subscribers/q/config'),
3435
...require('./subscribers/redis/config'),
3536
...require('./subscribers/redis-client/config'),
36-
...require('./subscribers/smithy-client/config'),
3737
...require('./subscribers/undici/config'),
3838
...require('./subscribers/when/config'),
3939
...require('./subscribers/winston/config')
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
const sendConfig = {
7-
path: './smithy-client/send.js',
7+
path: './aws-sdk/send.js',
88
instrumentations: [
99
// CJS
1010
{

lib/subscribers/aws-sdk-v3/converse-stream-handler.js renamed to lib/subscribers/aws-sdk/middleware/bedrock/converse-stream-handler.js

File renamed without changes.

lib/subscribers/aws-sdk-v3/bedrock.js renamed to lib/subscribers/aws-sdk/middleware/bedrock/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,9 +339,9 @@ function bedrockMiddleware(subscriber, clientConfig, next, context) {
339339

340340
/**
341341
* Bedrock middleware config following the same pattern as the old
342-
* bedrockMiddlewareConfig from lib/instrumentation/aws-sdk/v3/bedrock.js.
342+
* `bedrockMiddlewareConfig` from `lib/instrumentation/aws-sdk/v3/bedrock.js`.
343343
*
344-
* The `init` function is called by SmithyClientSendSubscriber to determine
344+
* The `init` function is called by `SmithyClientSendSubscriber` to determine
345345
* if the middleware should be registered. The `middleware` function is the
346346
* actual middleware added to the AWS client's middleware stack.
347347
*/
File renamed without changes.
Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
'use strict'
66

77
const Subscriber = require('../base')
8-
const bedrockMiddlewareConfig = require('../aws-sdk-v3/bedrock')
8+
const bedrockMiddlewareConfig = require('./middleware/bedrock')
99

1010
const UNKNOWN = 'Unknown'
1111
const MIDDLEWARE = Symbol('nrMiddleware')
@@ -15,6 +15,17 @@ const middlewareByClient = {
1515
BedrockRuntime: [bedrockMiddlewareConfig]
1616
}
1717

18+
/**
19+
* Subscriber for `@smithy/smithy-client` `Client.send()` calls. Registers
20+
* common AWS middleware (DT header suppression, response attributes) and
21+
* dispatches service-specific middleware via the `middlewareByClient` map.
22+
*
23+
* Only clients listed in `middlewareByClient` are handled here; all others
24+
* fall through to the existing shim-based instrumentation. This eliminates
25+
* the need for separate subscriber configs per AWS service package — a single
26+
* hook on `Client.send` covers every service, since all AWS SDK v3 clients
27+
* extend `@smithy/smithy-client.Client`.
28+
*/
1829
module.exports = class SmithyClientSendSubscriber extends Subscriber {
1930
constructor({ agent, logger }) {
2031
super({ agent, logger, channelName: 'nr_send', packageName: '@smithy/smithy-client' })

test/unit/instrumentation/aws-sdk/converse-stream-handler.test.js renamed to test/unit/subscribers/aws-sdk/converse-stream-handler.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
const test = require('node:test')
99
const assert = require('node:assert')
10-
const ConverseStreamHandler = require('#agentlib/subscribers/aws-sdk-v3/converse-stream-handler.js')
10+
const ConverseStreamHandler = require('#agentlib/subscribers/aws-sdk/middleware/bedrock/converse-stream-handler.js')
1111

1212
test.beforeEach((ctx) => {
1313
ctx.nr = {}

test/unit/instrumentation/aws-sdk/stream-handler.test.js renamed to test/unit/subscribers/aws-sdk/stream-handler.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const {
1111
BedrockCommand,
1212
BedrockResponse,
1313
} = require('#agentlib/llm-events/aws-bedrock/index.js')
14-
const StreamHandler = require('#agentlib/subscribers/aws-sdk-v3/stream-handler.js')
14+
const StreamHandler = require('#agentlib/subscribers/aws-sdk/middleware/bedrock/stream-handler.js')
1515

1616
test.beforeEach((ctx) => {
1717
ctx.nr = {}

0 commit comments

Comments
 (0)