-
Notifications
You must be signed in to change notification settings - Fork 422
Closed
Labels
points: 51-2 weeks1-2 weeks
Description
Description
It looks like this PR, broke our wrapReturn shim function which wraps an export in a Proxy. After updating to [email protected] you get
TypeError: getters.get(...)[name] is not a function
at Object.get (register.js:20:37)
at Object.set (shimmer.js:648:30)
at DatastoreShim.wrapEachProperty (shim.js:347:20)
at Array.forEach (<anonymous>)
at DatastoreShim.wrap (shim.js:334:14)
at DatastoreShim.wrapReturn (shim.js:398:15)
at instrumentPGNative (pg.js:61:10)
at initialize (pg.js:33:12)
at _firstPartyInstrumentation (shimmer.js:711:29)
at loadInstrumentation (shimmer.js:675:25)It's failing when we try to assign the exported module property as wrapped here
Steps to Reproduce
npm i import-in-the-middle@latestnpm run versioned:internal:major pg-esm
Expected Result
Tests pass
Actual Result
Tests fail
Metadata
Metadata
Assignees
Labels
points: 51-2 weeks1-2 weeks
Type
Projects
Status
Done: Issues recently completed