Skip to content

Commit c3d6c10

Browse files
authored
Merge pull request kubernetes#17856 from rramkumar1/versions-util-refactor
Deprecate version util in pkg/k8sversion
2 parents 370a257 + 07b6366 commit c3d6c10

File tree

3 files changed

+2
-167
lines changed

3 files changed

+2
-167
lines changed

pkg/k8sversion/version.go

Lines changed: 0 additions & 50 deletions
This file was deleted.

pkg/k8sversion/version_test.go

Lines changed: 0 additions & 114 deletions
This file was deleted.

pkg/model/components/context.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import (
2727
kopsmodel "k8s.io/kops/pkg/apis/kops/model"
2828
"k8s.io/kops/pkg/apis/kops/util"
2929
"k8s.io/kops/pkg/assets"
30-
"k8s.io/kops/pkg/k8sversion"
3130
"k8s.io/kops/upup/pkg/fi"
3231
"k8s.io/kops/util/pkg/vfs"
3332

@@ -140,14 +139,14 @@ func Image(component string, clusterSpec *kops.ClusterSpec, assetsBuilder *asset
140139
return "", fmt.Errorf("unable to parse assets as assetBuilder is not defined")
141140
}
142141

143-
kubernetesVersion, err := k8sversion.Parse(clusterSpec.KubernetesVersion)
142+
kubernetesVersion, err := kopsmodel.ParseKubernetesVersion(clusterSpec.KubernetesVersion)
144143
if err != nil {
145144
return "", err
146145
}
147146

148147
imageName := component
149148

150-
if !kopsmodel.IsBaseURL(clusterSpec.KubernetesVersion) {
149+
if !kubernetesVersion.IsBaseURL() {
151150
image := "registry.k8s.io/" + imageName + ":" + "v" + kubernetesVersion.String()
152151

153152
return assetsBuilder.RemapImage(image), nil

0 commit comments

Comments
 (0)