fixup! feat: add options to separate formatting and linting and export createConfig

Author: susnux

lib/configs/vue.ts

@@ -47,20 +47,6 @@ export function vue(options: ConfigOptions): Linter.Config[] {
 		files: GLOB_FILES_VUE,
 		name: 'nextcloud/vue/rules',
 		rules: {
-			// PascalCase components names for vuejs
-			'vue/component-name-in-template-casing': [
-				'error',
-				'PascalCase',
-			],
-			// space before self-closing elements
-			'vue/html-closing-bracket-spacing': 'error',
-			// no ending html tag on a new line
-			'vue/html-closing-bracket-newline': [
-				'error',
-				{
-					multiline: 'never',
-				},
-			],
 			// Enforce documentation of properties
 			'vue/require-prop-comment': options.isLibrary
 				? [
@@ -83,15 +69,6 @@ export function vue(options: ConfigOptions): Linter.Config[] {
 				'warn',
 				'default-false',
 			],
-			// Allow 3 attributes on the same line if singe line
-			'vue/max-attributes-per-line': [
-				'error',
-				{
-					singleline: {
-						max: 3,
-					},
-				},
-			],
 			// Component names should match their export names - readability and maintainability ("where does this component come from?")
 			'vue/match-component-import-name': 'error',
 			'vue/match-component-file-name': 'error',
@@ -141,6 +118,29 @@ export function vue(options: ConfigOptions): Linter.Config[] {
 			// same as in the codeStyle config but for the <template> in Vue files
 			'@nextcloud-l10n/non-breaking-space-vue': 'error',
 			'@nextcloud-l10n/enforce-ellipsis-vue': 'error',
+			// PascalCase components names for vuejs
+			'vue/component-name-in-template-casing': [
+				'error',
+				'PascalCase',
+			],
+			// space before self-closing elements
+			'vue/html-closing-bracket-spacing': 'error',
+			// no ending html tag on a new line
+			'vue/html-closing-bracket-newline': [
+				'error',
+				{
+					multiline: 'never',
+				},
+			],
+			// Allow 3 attributes on the same line if singe line
+			'vue/max-attributes-per-line': [
+				'error',
+				{
+					singleline: {
+						max: 3,
+					},
+				},
+			],
 			// Also enforce tabs for template
 			'vue/html-indent': [
 				'error',

lib/configs/vue2.ts

@@ -16,20 +16,7 @@ import { vue } from './vue.ts'
  * @param options - Configuration options defining the config preset flavor
  */
 export function vue2(options: ConfigOptions): Linter.Config[] {
-	if (options.linting === false) {
-		return []
-	}
-
-	return [
-		...restrictConfigFiles(
-			options.linting
-				? vuePlugin.configs['flat/vue2-recommended']
-				: vuePlugin.configs['flat/vue2-essential'],
-			GLOB_FILES_VUE,
-		),
-
-		...vue(options),
-
+	const formattingRules: Linter.Config[] = [
 		{
 			rules: {
 			// custom event naming convention
@@ -43,7 +30,17 @@ export function vue2(options: ConfigOptions): Linter.Config[] {
 				],
 			},
 			files: GLOB_FILES_VUE,
-			name: 'nextcloud/vue2/rules',
+			name: 'nextcloud/vue2/stylistic-rules',
 		},
 	]
+
+	return [
+		// the essential rules contain rules that
+		...(options.linting && !options.formatting ? restrictConfigFiles(vuePlugin.configs['flat/vue2-essential'], GLOB_FILES_VUE) : []),
+		...(options.linting && options.formatting ? restrictConfigFiles(vuePlugin.configs['flat/vue2-recommended'], GLOB_FILES_VUE) : []),
+
+		...vue(options),
+
+		...(options.formatting ? formattingRules : []),
+	]
 }

lib/configs/vue3.ts

@@ -17,12 +17,9 @@ import { vue } from './vue.ts'
  */
 export function vue3(options: ConfigOptions): Linter.Config[] {
 	return [
-		...restrictConfigFiles(
-			options.linting
-				? vuePlugin.configs['flat/recommended']
-				: vuePlugin.configs['flat/essential'],
-			GLOB_FILES_VUE,
-		),
+		// the essential rules contain rules that
+		...(options.linting && !options.formatting ? restrictConfigFiles(vuePlugin.configs['flat/essential'], GLOB_FILES_VUE) : []),
+		...(options.linting && options.formatting ? restrictConfigFiles(vuePlugin.configs['flat/recommended'], GLOB_FILES_VUE) : []),
 
 		...vue(options),