Merge pull request #1837 from nextcloud-libraries/fix/sanitize-guest-nick-stable6

[stable6] fix: display guest name validity

Author: susnux

l10n/messages.pot

@@ -2,12 +2,21 @@ msgid ""
 msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 
+msgid "\"{char}\" is not allowed inside a name."
+msgstr ""
+
+msgid "\"{extension}\" is not an allowed name."
+msgstr ""
+
 msgid "\"{name}\" is an invalid folder name."
 msgstr ""
 
 msgid "\"{name}\" is not an allowed folder name"
 msgstr ""
 
+msgid "\"{segment}\" is a reserved name and not allowed."
+msgstr ""
+
 msgid "\"/\" is not allowed inside a folder name."
 msgstr ""
 
@@ -76,6 +85,9 @@ msgstr ""
 msgid "Home"
 msgstr ""
 
+msgid "Invalid name."
+msgstr ""
+
 msgid "Modified"
 msgstr ""
 
@@ -88,6 +100,15 @@ msgstr ""
 msgid "Name"
 msgstr ""
 
+msgid "Names must not be empty."
+msgstr ""
+
+msgid "Names must not end with \"{extension}\"."
+msgstr ""
+
+msgid "Names must not start with a dot."
+msgstr ""
+
 msgid "New"
 msgstr ""
 

lib/components/PublicAuthPrompt.vue

@@ -39,12 +39,12 @@ import { getBuilder } from '@nextcloud/browser-storage'
 import { setGuestNickname } from '@nextcloud/auth'
 import { showError } from '@nextcloud/dialogs'
 
-import NcButton from '@nextcloud/vue/components/NcButton'
 import NcDialog from '@nextcloud/vue/components/NcDialog'
 import NcNoteCard from '@nextcloud/vue/components/NcNoteCard'
 import NcTextField from '@nextcloud/vue/components/NcTextField'
 
 import { t } from '../utils/l10n.ts'
+import { getGuestNameValidity } from '../utils/guestNameValidity.ts'
 
 const storage = getBuilder('public').build()
 
@@ -158,6 +158,19 @@ export default defineComponent({
 			},
 			immediate: true,
 		},
+		
+		name() {
+			// Check validity of the new name
+			const newName = this.name.trim?.() || ''
+			const input = (this.$refs.input as Vue|undefined)?.$el.querySelector('input')
+			if (!input) {
+				return
+			}
+
+			const validity = getGuestNameValidity(newName)
+			input.setCustomValidity(validity)
+			input.reportValidity()
+		},
 	},
 
 	methods: {

lib/utils/guestNameValidity.ts

@@ -0,0 +1,45 @@
+/*!
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+import { InvalidFilenameError, InvalidFilenameErrorReason, validateFilename } from '@nextcloud/files'
+import { t } from '../utils/l10n.ts'
+
+/**
+ * Get the validity of a filename (empty if valid).
+ * This can be used for `setCustomValidity` on input elements
+ *
+ * @param name The filename
+ */
+export function getGuestNameValidity(name: string): string {
+	if (name.trim() === '') {
+		return t('Names must not be empty.')
+	}
+
+	if (name.startsWith('.')) {
+		return t('Names must not start with a dot.')
+	}
+
+	try {
+		validateFilename(name)
+		return ''
+	} catch (error) {
+		if (!(error instanceof InvalidFilenameError)) {
+			throw error
+		}
+
+		switch (error.reason) {
+			case InvalidFilenameErrorReason.Character:
+				return t('"{char}" is not allowed inside a name.', { char: error.segment })
+			case InvalidFilenameErrorReason.ReservedName:
+				return t('"{segment}" is a reserved name and not allowed.', { segment: error.segment })
+			case InvalidFilenameErrorReason.Extension:
+				if (error.segment.match(/\.[a-z]/i)) {
+					return t('"{extension}" is not an allowed name.', { extension: error.segment })
+				}
+				return t('Names must not end with "{extension}".', { extension: error.segment })
+			default:
+				return t('Invalid name.')
+		}
+	}
+}