fix: make lib side effects free

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

Author: ShGKme

lib/globals.d.ts

@@ -8,12 +8,12 @@
 import type { PluralFunction, Translations } from './registry.ts'
 
 declare global {
-	var _nc_l10n_locale: string
-	var _nc_l10n_language: string
-	var _nc_l10n_timezone: string
+	var _nc_l10n_locale: string | undefined
+	var _nc_l10n_language: string | undefined
+	var _nc_l10n_timezone: string | undefined
 
-	var _oc_l10n_registry_translations: Record<string, Translations>
-	var _oc_l10n_registry_plural_functions: Record<string, PluralFunction>
+	var _oc_l10n_registry_translations: Record<string, Translations> | undefined
+	var _oc_l10n_registry_plural_functions: Record<string, PluralFunction> | undefined
 }
 
 export {}

lib/locale.ts

@@ -9,6 +9,9 @@ import { getCapabilities } from '@nextcloud/capabilities'
  * Returns the user's locale
  */
 export function getLocale(): string {
+	globalThis._nc_l10n_locale ??= (typeof document !== 'undefined' && document.documentElement.dataset.locale)
+		|| Intl.DateTimeFormat().resolvedOptions().locale.replaceAll(/-/g, '_')
+
 	return globalThis._nc_l10n_locale
 }
 
@@ -40,6 +43,9 @@ export function setLocale(locale: string): void {
  * Returns the user's language
  */
 export function getLanguage(): string {
+	globalThis._nc_l10n_language ??= (typeof document !== 'undefined' && document.documentElement.lang)
+		|| (globalThis.navigator?.language ?? 'en')
+
 	return globalThis._nc_l10n_language
 }
 
@@ -136,11 +142,3 @@ export function isRTL(language?: string): boolean {
 
 	return rtlLanguages.includes(languageCode)
 }
-
-// Initialize global state if needed (e.g. when not in DOM context like on WebWorker)
-
-globalThis._nc_l10n_locale ??= (typeof document !== 'undefined' && document.documentElement.dataset.locale)
-	|| Intl.DateTimeFormat().resolvedOptions().locale.replaceAll(/-/g, '_')
-
-globalThis._nc_l10n_language ??= (typeof document !== 'undefined' && document.documentElement.lang)
-	|| (globalThis.navigator?.language ?? 'en')

lib/registry.ts

@@ -43,7 +43,9 @@ export interface AppTranslations {
  */
 export function hasAppTranslations(appId: string): boolean {
 	return (
-		appId in globalThis._oc_l10n_registry_translations
+		globalThis._oc_l10n_registry_translations !== undefined
+		&& globalThis._oc_l10n_registry_plural_functions !== undefined
+		&& appId in globalThis._oc_l10n_registry_translations
 		&& appId in globalThis._oc_l10n_registry_plural_functions
 	)
 }
@@ -64,6 +66,9 @@ export function registerAppTranslations(
 		throw new Error('Invalid appId')
 	}
 
+	globalThis._oc_l10n_registry_translations ??= {}
+	globalThis._oc_l10n_registry_plural_functions ??= {}
+
 	globalThis._oc_l10n_registry_translations[appId] = {
 		...(globalThis._oc_l10n_registry_translations[appId] || {}),
 		...translations,
@@ -78,8 +83,8 @@ export function registerAppTranslations(
  * @param appId - The app id
  */
 export function unregisterAppTranslations(appId: string): void {
-	delete globalThis._oc_l10n_registry_translations[appId]
-	delete globalThis._oc_l10n_registry_plural_functions[appId]
+	delete globalThis._oc_l10n_registry_translations?.[appId]
+	delete globalThis._oc_l10n_registry_plural_functions?.[appId]
 }
 
 /**
@@ -89,11 +94,7 @@ export function unregisterAppTranslations(appId: string): void {
  */
 export function getAppTranslations(appId: string): AppTranslations {
 	return {
-		translations: globalThis._oc_l10n_registry_translations[appId] ?? {},
-		pluralFunction: globalThis._oc_l10n_registry_plural_functions[appId] ?? ((number: number) => number),
+		translations: globalThis._oc_l10n_registry_translations?.[appId] ?? {},
+		pluralFunction: globalThis._oc_l10n_registry_plural_functions?.[appId] ?? ((number: number) => number),
 	}
 }
-
-// Initialize global state if needed
-globalThis._oc_l10n_registry_translations ??= {}
-globalThis._oc_l10n_registry_plural_functions ??= {}

package.json

@@ -16,6 +16,7 @@
   },
   "license": "GPL-3.0-or-later",
   "author": "Nextcloud GmbH and Nextcloud contributors",
+  "sideEffects": false,
   "type": "module",
   "exports": {
     ".": {