Skip to content

Commit 656957a

Browse files
committed
style(NcProgressBar): fix BEM naming, use correct variable, and update code style
Signed-off-by: nikhil2297 <nikhillohar2297@gmail.com>
1 parent 661c348 commit 656957a

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/components/NcProgressBar/NcProgressBar.vue

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ This is a simple progress bar component.
2424
<NcProgressBar :value="60" size="medium" />
2525
<br />
2626
Custom size (changes the progress bar height)
27-
<NcProgressBar :value="55" :size="8" showValue="true" />
27+
<NcProgressBar :value="55" :size="8" showValue />
2828
</span>
2929
</template>
3030
```
@@ -162,14 +162,14 @@ const clickableAreaSmall = Number.parseInt(window.getComputedStyle(document.body
162162
:cy="circleCenterPosition" />
163163
</svg>
164164
</span>
165-
<div v-else class="progress-bar--container">
165+
<div v-else class="progress-bar-container">
166166
<progress
167167
class="progress-bar progress-bar--linear vue"
168168
:class="{ 'progress-bar--error': error }"
169-
:value="value"
169+
:value
170170
max="100" />
171171

172-
<span v-if="showValue" class="progress-bar--value">{{ value }}%</span>
172+
<span v-if="showValue" class="progress-bar__value">{{ value }}%</span>
173173
</div>
174174
</template>
175175

@@ -219,15 +219,15 @@ const clickableAreaSmall = Number.parseInt(window.getComputedStyle(document.body
219219
}
220220
}
221221
222-
&--container {
222+
&-container {
223223
display: flex;
224224
align-items: center;
225-
gap: 0.5em;
225+
gap: calc(2 * var(--default-grid-baseline));
226226
}
227227
228-
&--value {
229-
font-size: var(--font-size-small, 0.875rem);
230-
color: var(--color-text-secondary);
228+
&__value {
229+
font-size: var(--font-size-small, 13px);
230+
color: var(--color-main-text);
231231
font-variant-numeric: tabular-nums;
232232
min-width: 4ch;
233233
text-align: end;

0 commit comments

Comments
 (0)