Skip to content

Commit 73eb961

Browse files
Merge pull request #5167 from nextcloud-libraries/fix/noid/styleguide-teleport
[next] fix(docs): bring back NcAppSidebar in docs
2 parents 0ab9b58 + 0710c9a commit 73eb961

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

src/components/NcContent/NcContent.vue

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ It also will set the skip content buttons needed for accessibility.
3434

3535
```vue
3636
<template>
37+
<div id="skip-actions" />
3738
<NcContent app-name="forms">
3839
<NcAppNavigation>
3940
<template #list>
@@ -49,9 +50,9 @@ It also will set the skip content buttons needed for accessibility.
4950
<h2>Your main app content here</h2>
5051
<NcButton @click="opened = !opened">Toggle sidebar</NcButton>
5152
</NcAppContent>
52-
<!-- Todo: Bring back once migrated
53-
<NcAppSidebar v-if="opened" name="cat-picture.jpg" @close="opened=false"></NcAppSidebar>
54-
-->
53+
<NcAppSidebar v-if="opened" name="cat-picture.jpg" @close="opened=false">
54+
Sidebar content
55+
</NcAppSidebar>
5556
</NcContent>
5657
</template>
5758
<script>
@@ -68,6 +69,13 @@ It also will set the skip content buttons needed for accessibility.
6869
}
6970
}
7071
</script>
72+
<style>
73+
#content-vue {
74+
position: relative;
75+
width: 800px;
76+
height: 400px;
77+
}
78+
</style>
7179
```
7280

7381
</docs>
@@ -100,7 +108,6 @@ It also will set the skip content buttons needed for accessibility.
100108
:svg="currentImage"
101109
size="auto" />
102110
</div>
103-
&nbsp;<!-- TODO: Remove with vue3! This is a bug of vue-simple-portal that does not allow a single child, ref LinusBorg/vue-simple-portal#20 -->
104111
</Teleport>
105112
<slot />
106113
</div>

0 commit comments

Comments
 (0)