log warnings to give admins more infos about possibly miscalculated activities.

Signed-off-by: Jan Messer <jan@mtec-studios.ch>

Author: Messj1

lib/FilesHooks.php

@@ -396,7 +396,16 @@ protected function fileMoving($oldPath, $newPath) {
 		}
 		$accessList = $this->getUserPathsFromPath($parentPath, $parentOwner);
 		$affectedUsers = $accessList['users'];
-		$oldUsers = $this->oldAccessList['users'] ?? [];
+		$oldAccessList = $this->oldAccessList;
+		if($oldAccessList === null) {
+			$this->logger->warning("Something fishy happens: function fileMove was not finished: {oldPath} -> {path} : {uidOwner}",
+				['oldPath'=>$oldPath, 'path'=> $parentPath, 'uidOwner'=>$parentOwner]);
+			$oldAccessList = [
+				'users' => [],
+				'remotes' => [],
+			];
+		}
+		$oldUsers = $oldAccessList['users'];
 
 		// file can be shared using GroupFolders, including ACL check
 		if ($this->config->getSystemValueBool('activity_use_cached_mountpoints', false)) {
@@ -416,7 +425,7 @@ protected function fileMoving($oldPath, $newPath) {
 		$moveUsers = array_intersect($beforeUsers, $afterUsers);
 		$this->generateMoveActivities($moveUsers, $oldUsers, $affectedUsers, $fileId, $oldFileName, $parentId, $fileName);
 
-		$beforeRemotes = $this->oldAccessList['remotes'] ?? [];
+		$beforeRemotes = $oldAccessList['remotes'];
 		$afterRemotes = $accessList['remotes'];
 
 		$addRemotes = $deleteRemotes = $moveRemotes = [];
@@ -570,13 +579,17 @@ protected function getUserPathsFromPath($path, $uidOwner) {
 		try {
 			$node = $this->rootFolder->getUserFolder($uidOwner)->get($path);
 		} catch (NotFoundException $e) {
+			$this->logger->warning('Something fishy happens: Path "{path}" with owner "{uidOwner}" was not found',
+				['path'=> $path, 'uidOwner'=>$uidOwner]);
 			return [
 				'users' => [],
 				'remotes' => [],
 			];
 		}
 
 		if (!$node instanceof Node) {
+			$this->logger->warning('Something fishy happens: Path "{path}" of "{uidOwner}" is not a valid type.',
+				['path'=> $path, 'uidOwner'=>$uidOwner]);
 			return [
 				'users' => [],
 				'remotes' => [],