Skip to content

Commit 2c45382

Browse files
Merge pull request #25 from nextcloud/check_for_unshareable_federated_shares
Check for unshareable federated shares
2 parents 64d7734 + d79bfe5 commit 2c45382

File tree

2 files changed

+36
-20
lines changed

2 files changed

+36
-20
lines changed

src/com/owncloud/android/lib/resources/shares/OCShare.java

Lines changed: 29 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,13 @@
4040
*
4141
*/
4242
public class OCShare implements Parcelable, Serializable {
43-
44-
/** Generated - should be refreshed every time the class changes!! */
45-
private static final long serialVersionUID = 4124975224281327921L;
4643

47-
private static final String TAG = OCShare.class.getSimpleName();
44+
/**
45+
* Generated - should be refreshed every time the class changes!!
46+
*/
47+
private static final long serialVersionUID = 4124975224281327921L;
48+
49+
private static final String TAG = OCShare.class.getSimpleName();
4850

4951
public static final int DEFAULT_PERMISSION = -1;
5052
public static final int READ_PERMISSION_FLAG = 1;
@@ -53,24 +55,33 @@ public class OCShare implements Parcelable, Serializable {
5355
public static final int DELETE_PERMISSION_FLAG = 8;
5456
public static final int SHARE_PERMISSION_FLAG = 16;
5557
public static final int MAXIMUM_PERMISSIONS_FOR_FILE =
56-
READ_PERMISSION_FLAG +
57-
UPDATE_PERMISSION_FLAG +
58-
SHARE_PERMISSION_FLAG
58+
READ_PERMISSION_FLAG +
59+
UPDATE_PERMISSION_FLAG +
60+
SHARE_PERMISSION_FLAG
5961
;
6062
public static final int MAXIMUM_PERMISSIONS_FOR_FOLDER =
61-
MAXIMUM_PERMISSIONS_FOR_FILE +
62-
CREATE_PERMISSION_FLAG +
63-
DELETE_PERMISSION_FLAG
63+
MAXIMUM_PERMISSIONS_FOR_FILE +
64+
CREATE_PERMISSION_FLAG +
65+
DELETE_PERMISSION_FLAG
66+
;
67+
public static final int FEDERATED_PERMISSIONS_FOR_FILE_UP_TO_OC9 =
68+
READ_PERMISSION_FLAG +
69+
UPDATE_PERMISSION_FLAG
70+
;
71+
public static final int FEDERATED_PERMISSIONS_FOR_FILE_AFTER_OC9 =
72+
READ_PERMISSION_FLAG +
73+
UPDATE_PERMISSION_FLAG +
74+
SHARE_PERMISSION_FLAG
6475
;
65-
public static final int FEDERATED_PERMISSIONS_FOR_FILE =
66-
READ_PERMISSION_FLAG +
67-
UPDATE_PERMISSION_FLAG
76+
public static final int FEDERATED_PERMISSIONS_FOR_FOLDER_UP_TO_OC9 =
77+
READ_PERMISSION_FLAG +
78+
UPDATE_PERMISSION_FLAG +
79+
CREATE_PERMISSION_FLAG +
80+
DELETE_PERMISSION_FLAG
6881
;
69-
public static final int FEDERATED_PERMISSIONS_FOR_FOLDER =
70-
READ_PERMISSION_FLAG +
71-
UPDATE_PERMISSION_FLAG +
72-
CREATE_PERMISSION_FLAG +
73-
DELETE_PERMISSION_FLAG
82+
public static final int FEDERATED_PERMISSIONS_FOR_FOLDER_AFTER_OC9 =
83+
FEDERATED_PERMISSIONS_FOR_FOLDER_UP_TO_OC9 +
84+
SHARE_PERMISSION_FLAG
7485
;
7586

7687
private long mId;

src/com/owncloud/android/lib/resources/status/OwnCloudVersion.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,14 @@ public class OwnCloudVersion implements Comparable<OwnCloudVersion> {
5454

5555
public static final int MINIMUM_VERSION_CAPABILITIES_API = 0x08010000; // 8.1
5656

57+
private static final int MINIMUM_VERSION_WITH_NOT_RESHAREABLE_FEDERATED = 0x09010000; // 9.1
58+
5759
public static final int MINIMUM_VERSION_FOR_SELF_API = 0x0B000200;
5860

5961
public static final int MINIMUM_VERSION_FOR_SEARCH_API = 0x0C000000;
6062

6163
private static final int MAX_DOTS = 3;
62-
64+
6365
// format is in version
6466
// 0xAABBCCDD
6567
// for version AA.BB.CC.DD
@@ -164,10 +166,13 @@ public boolean isVersionWithCapabilitiesAPI(){
164166
return (mVersion>= MINIMUM_VERSION_CAPABILITIES_API);
165167
}
166168

169+
public boolean isNotReshareableFederatedSupported() {
170+
return (mVersion >= MINIMUM_VERSION_WITH_NOT_RESHAREABLE_FEDERATED);
171+
}
172+
167173
public boolean isSelfSupported() {
168174
return (mVersion >= MINIMUM_VERSION_FOR_SELF_API);
169175
}
170-
171176
public boolean isSearchSupported() {
172177
return (mVersion >= MINIMUM_VERSION_FOR_SEARCH_API);
173178
}

0 commit comments

Comments
 (0)