Skip to content

Commit 620d18d

Browse files
Merge pull request #1512 from nextcloud/fix-npe
Fix NPE
2 parents 961754e + 329bccd commit 620d18d

File tree

4 files changed

+12
-11
lines changed

4 files changed

+12
-11
lines changed

src/main/java/com/owncloud/android/MainApp.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ public static void initAutoUpload() {
186186

187187
initiateExistingAutoUploadEntries();
188188

189-
FilesSyncHelper.scheduleFilesSyncIfNeeded();
189+
FilesSyncHelper.scheduleFilesSyncIfNeeded(mContext);
190190
FilesSyncHelper.restartJobsIfNeeded();
191191

192192
ReceiversHelper.registerNetworkChangeReceiver();

src/main/java/com/owncloud/android/jobs/NContentObserverJob.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public boolean onStartJob(JobParameters params) {
5656
.schedule();
5757
}
5858

59-
FilesSyncHelper.scheduleNJobs(true);
59+
FilesSyncHelper.scheduleNJobs(true, getApplicationContext());
6060
}
6161

6262
return true;

src/main/java/com/owncloud/android/ui/activity/SyncedFoldersActivity.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,7 @@ public void onSyncStatusToggleClick(int section, SyncedFolderDisplayItem syncedF
502502
String syncedFolderInitiatedKey = "syncedFolderIntitiated_" + syncedFolderDisplayItem.getId();
503503
arbitraryDataProvider.deleteKeyForAccount("global", syncedFolderInitiatedKey);
504504
}
505-
FilesSyncHelper.scheduleNJobs(false);
505+
FilesSyncHelper.scheduleNJobs(false, getApplicationContext());
506506

507507
}
508508

@@ -555,7 +555,7 @@ public void onSaveSyncedFolderPreference(SyncedFolderParcelable syncedFolder) {
555555
String syncedFolderInitiatedKey = "syncedFolderIntitiated_" + newCustomFolder.getId();
556556
arbitraryDataProvider.deleteKeyForAccount("global", syncedFolderInitiatedKey);
557557
}
558-
FilesSyncHelper.scheduleNJobs(false);
558+
FilesSyncHelper.scheduleNJobs(false, getApplicationContext());
559559
}
560560
mAdapter.addSyncFolderItem(newCustomFolder);
561561
} else {
@@ -575,7 +575,7 @@ public void onSaveSyncedFolderPreference(SyncedFolderParcelable syncedFolder) {
575575
String syncedFolderInitiatedKey = "syncedFolderIntitiated_" + item.getId();
576576
arbitraryDataProvider.deleteKeyForAccount("global", syncedFolderInitiatedKey);
577577
}
578-
FilesSyncHelper.scheduleNJobs(false);
578+
FilesSyncHelper.scheduleNJobs(false, getApplicationContext());
579579
}
580580
} else {
581581
// existing synced folder setup to be updated
@@ -586,7 +586,7 @@ public void onSaveSyncedFolderPreference(SyncedFolderParcelable syncedFolder) {
586586
String syncedFolderInitiatedKey = "syncedFolderIntitiated_" + item.getId();
587587
arbitraryDataProvider.deleteKeyForAccount("global", syncedFolderInitiatedKey);
588588
}
589-
FilesSyncHelper.scheduleNJobs(false);
589+
FilesSyncHelper.scheduleNJobs(false, getApplicationContext());
590590
}
591591

592592
mAdapter.setSyncFolderItem(syncedFolder.getSection(), item);

src/main/java/com/owncloud/android/utils/FilesSyncHelper.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -253,9 +253,8 @@ public static boolean isContentObserverJobScheduled() {
253253
return false;
254254
}
255255

256-
public static void scheduleNJobs(boolean force) {
257-
SyncedFolderProvider syncedFolderProvider = new SyncedFolderProvider(MainApp.getAppContext().
258-
getContentResolver());
256+
public static void scheduleNJobs(boolean force, Context context) {
257+
SyncedFolderProvider syncedFolderProvider = new SyncedFolderProvider(context.getContentResolver());
259258

260259

261260
boolean hasVideoFolders = false;
@@ -282,15 +281,17 @@ public static void scheduleNJobs(boolean force) {
282281
}
283282
}
284283

285-
public static void scheduleFilesSyncIfNeeded() {
284+
public static void scheduleFilesSyncIfNeeded(Context context) {
286285
// always run this because it also allows us to perform retries of manual uploads
287286
new JobRequest.Builder(FilesSyncJob.TAG)
288287
.setPeriodic(900000L, 300000L)
289288
.setUpdateCurrent(true)
290289
.build()
291290
.schedule();
292291

293-
scheduleNJobs(false);
292+
if (context != null) {
293+
scheduleNJobs(false, context);
294+
}
294295
}
295296

296297
@RequiresApi(api = Build.VERSION_CODES.N)

0 commit comments

Comments
 (0)