fix: check deleted files for local behaviour delete

Signed-off-by: alperozturk <[email protected]>

Author: alperozturk96

app/src/main/java/com/nextcloud/client/jobs/autoUpload/AutoUploadWorker.kt

@@ -325,8 +325,7 @@ class AutoUploadWorker(
                     // if local file deleted, upload process cannot be started or retriable thus needs to be removed
                     if (path.isEmpty() || !file.exists()) {
                         Log_OC.w(TAG, "detected non-existing local file, removing entity")
-                        repository.deleteByLocalPathAndId(path, id)
-                        uploadsStorageManager.removeUpload(upload)
+                        deleteNonExistingFile(path, id, upload)
                         continue
                     }
 
@@ -383,6 +382,11 @@ class AutoUploadWorker(
         }
     }
 
+    private suspend fun deleteNonExistingFile(path: String, id: Int, upload: OCUpload) {
+        repository.deleteByLocalPathAndId(path, id)
+        uploadsStorageManager.removeUpload(upload)
+    }
+
     private fun createEntityAndUpload(user: User, localPath: String, remotePath: String): Pair<UploadEntity, OCUpload> {
         val (needsCharging, needsWifi, uploadAction) = getUploadSettings(syncedFolder)
         Log_OC.d(TAG, "creating oc upload for ${user.accountName}")

app/src/main/java/com/owncloud/android/operations/UploadFileOperation.java

@@ -1283,6 +1283,19 @@ public void handleLocalBehaviour() {
         handleLocalBehaviour(temporalFile, expectedFile, originalFile, client);
     }
 
+    private void deleteNonExistingFile(File file) {
+        if (file.exists()) {
+            return;
+        }
+
+        Log_OC.d(TAG, "deleting non-existing file from upload list and file list");
+
+        uploadsStorageManager.removeUpload(mOCUploadId);
+
+        // some chunks can be uploaded and can still exists in db thus we have to remove it as well
+        getStorageManager().removeFile(mFile, true, true);
+    }
+
     private void handleLocalBehaviour(File temporalFile,
                                       File expectedFile,
                                       File originalFile,
@@ -1293,6 +1306,9 @@ private void handleLocalBehaviour(File temporalFile,
                     Files.delete(originalFile.toPath());
                 } catch (IOException e) {
                     Log_OC.e(TAG, "Could not delete original file: " + originalFile.getAbsolutePath(), e);
+
+                    // if file is not exists we should only delete from our app
+                    deleteNonExistingFile(originalFile);
                 }
                 mFile.setStoragePath("");
                 getStorageManager().deleteFileInMediaScan(originalFile.getAbsolutePath());