Skip to content

Commit 935fc00

Browse files
Merge pull request #16386 from nextcloud/backport/16382/stable-3.35
[stable-3.35] fix(shared search): remove duplicate entries
2 parents a6980c6 + 0253873 commit 935fc00

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

app/src/main/java/com/owncloud/android/ui/adapter/OCShareToOCFileConverter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ object OCShareToOCFileConverter {
8484
}
8585

8686
storageManager?.saveShares(newShares, accountName)
87-
cachedFiles + newFiles
87+
(cachedFiles + newFiles).distinctBy { it.remotePath }
8888
}
8989

9090
private fun buildOcFile(path: String, shares: List<OCShare>): OCFile {

app/src/main/java/com/owncloud/android/ui/fragment/OCFileListSearchTask.kt

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -176,21 +176,26 @@ class OCFileListSearchTask(
176176
return@withContext FileStorageUtils.sortOcFolderDescDateModifiedWithoutFavoritesFirst(newList)
177177
}
178178

179-
if (searchType != SearchType.SHARED_FILTER) {
180-
val foldersBeforeFiles = preferences.isSortFoldersBeforeFiles()
181-
val favoritesFirst = preferences.isSortFavoritesFirst()
179+
val foldersBeforeFiles = preferences.isSortFoldersBeforeFiles()
180+
val favoritesFirst = preferences.isSortFavoritesFirst()
182181

183-
val sortOrder =
184-
if (searchType == SearchType.FAVORITE_SEARCH) {
185-
preferences.getSortOrderByType(FileSortOrder.Type.favoritesListView)
186-
} else {
187-
preferences.getSortOrderByFolder(folder)
188-
}
182+
val sortOrder = when (searchType) {
183+
SearchType.FAVORITE_SEARCH -> {
184+
preferences.getSortOrderByType(FileSortOrder.Type.favoritesListView)
185+
}
189186

190-
setNewSortOrder(sortOrder)
191-
newList = sortOrder.sortCloudFiles(newList, foldersBeforeFiles, favoritesFirst)
187+
SearchType.SHARED_FILTER -> {
188+
FileSortOrder.SORT_A_TO_Z
189+
}
190+
191+
else -> {
192+
preferences.getSortOrderByFolder(folder)
193+
}
192194
}
193195

196+
setNewSortOrder(sortOrder)
197+
newList = sortOrder.sortCloudFiles(newList, foldersBeforeFiles, favoritesFirst)
198+
194199
return@withContext newList
195200
}
196201

0 commit comments

Comments
 (0)