Skip to content

Commit ee658aa

Browse files
committed
fix action bar press back from unified search fragment and when fda created or recreated
Signed-off-by: alperozturk <[email protected]>
1 parent 9291beb commit ee658aa

File tree

4 files changed

+25
-15
lines changed

4 files changed

+25
-15
lines changed

app/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -713,19 +713,6 @@ public void startPhotoSearch(int id) {
713713
launchActivityForSearch(searchEvent, id);
714714
}
715715

716-
private void handleSearchEvents(SearchEvent searchEvent, int menuItemId) {
717-
if (this instanceof FileDisplayActivity) {
718-
final Fragment leftFragment = ((FileDisplayActivity) this).getLeftFragment();
719-
if (leftFragment instanceof GalleryFragment || leftFragment instanceof SharedListFragment) {
720-
launchActivityForSearch(searchEvent, menuItemId);
721-
} else {
722-
EventBus.getDefault().post(searchEvent);
723-
}
724-
} else {
725-
launchActivityForSearch(searchEvent, menuItemId);
726-
}
727-
}
728-
729716
private void launchActivityForSearch(SearchEvent searchEvent, int menuItemId) {
730717
DrawerActivity.menuItemId = menuItemId;
731718
Intent intent = new Intent(getApplicationContext(), FileDisplayActivity.class);
@@ -1477,6 +1464,14 @@ public static boolean isToolbarStyleSearch() {
14771464
menuItemId == R.id.nav_personal_files;
14781465
}
14791466

1467+
public static boolean isMenuItemIdBelongsToSearchType() {
1468+
return menuItemId == R.id.nav_favorites ||
1469+
menuItemId == R.id.nav_shared ||
1470+
menuItemId == R.id.nav_on_device ||
1471+
menuItemId == R.id.nav_recently_modified ||
1472+
menuItemId == R.id.nav_gallery;
1473+
}
1474+
14801475
public static int getPreviousMenuItemId() {
14811476
return previousMenuItemId;
14821477
}

app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,11 @@ class FileDisplayActivity :
307307
mSwitchAccountButton.setOnClickListener { v: View? -> showManageAccountsDialog() }
308308
mNotificationButton.setOnClickListener { v: View? -> startActivity(NotificationsActivity::class.java) }
309309
fastScrollUtils.fixAppBarForFastScroll(binding.appbar.appbar, binding.rootLayout)
310+
311+
// reset ui states when file display activity created/recrated
312+
listOfFilesFragment?.resetSearchAttributes()
313+
menuItemId = R.id.nav_all_files
314+
setNavigationViewItemChecked()
310315
}
311316

312317
private fun initTaskRetainerFragment() {

app/src/main/java/com/owncloud/android/ui/activity/ToolbarActivity.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,17 @@ private OCFileDepth getCurrentDirDepth() {
181181
}
182182

183183
private SearchType getSearchType() {
184-
OCFileListFragment fragment = getOCFileListFragment();
184+
final OCFileListFragment fragment = getOCFileListFragment();
185+
186+
// if current navigation not matches, reset search event
187+
if (!DrawerActivity.isMenuItemIdBelongsToSearchType()) {
188+
if (fragment != null) {
189+
fragment.resetSearchAttributes();
190+
}
191+
192+
return SearchType.NO_SEARCH;
193+
}
194+
185195
if (fragment != null) {
186196
return fragment.getCurrentSearchType();
187197
}

app/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1784,7 +1784,7 @@ private void resetMenuItems() {
17841784
updateSortAndGridMenuItems();
17851785
}
17861786

1787-
private void resetSearchAttributes() {
1787+
public void resetSearchAttributes() {
17881788
searchFragment = false;
17891789
searchEvent = null;
17901790
currentSearchType = NO_SEARCH;

0 commit comments

Comments
 (0)