Merge pull request #794 from nextcloud/feat/axios-js-tests

test: add axios-dependent tests for filesplugin icon loading and fileactions

Author: oleksandr-nc

.github/workflows/node-build.yml

@@ -45,7 +45,7 @@ jobs:
           fallbackNpm: "^10"
 
       - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
-        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v3
+        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           persist-credentials: false
           node-version: ${{ steps.versions.outputs.nodeVersion }}

.github/workflows/node.yml

@@ -86,6 +86,11 @@ jobs:
           npm ci
           npm run build --if-present
 
+      - name: Reset source maps
+        # Source map `mappings` are non-deterministic across different build environments
+        # Reset tracked .map files so only JS and license changes are checked.
+        run: git checkout -- '*.js.map' 2>/dev/null || true
+
       - name: Check build changes
         run: |
           bash -c "[[ ! \"`git status --porcelain `\" ]] || (echo 'Please recompile and commit the assets, see the section \"Show changes on failure\" for details' && exit 1)"

js/app_api-filesplugin.js.map

@@ -20,7 +20,7 @@ export function isSvgContentType(ct) {
 	return (ct || '').toLowerCase().startsWith('image/svg+xml')
 }
 
-function loadExAppInlineSvgIcon(appId, route) {
+export function loadExAppInlineSvgIcon(appId, route) {
 	const url = generateAppAPIProxyUrl(appId, route)
 	return axios.get(url, {
 		responseType: 'text',
@@ -86,7 +86,7 @@ export function generateExAppUIPageUrl(appId, route) {
 	return generateUrl(`/apps/app_api/embedded/${appId}/${route}`)
 }
 
-function registerFileAction33(fileAction, iconProvider) {
+export function registerFileAction33(fileAction, iconProvider) {
 	const handlerUrl = generateAppAPIProxyUrl(fileAction.appid, fileAction.action_handler)
 	const isV2 = ('version' in fileAction && fileAction.version === '2.0')