perf: use getExistingUser for getUsersForShare

icewind1991 · icewind1991 · commit 9702f2ce842d · 2026-01-19T18:19:00.000+01:00
Signed-off-by: Robin Appelman &lt;robin@icewind.nl&gt;
diff --git a/lib/ShareByCircleProvider.php b/lib/ShareByCircleProvider.php
@@ -52,7 +52,6 @@
 use OCP\Files\NotFoundException;
 use OCP\IL10N;
 use OCP\IURLGenerator;
-use OCP\IUser;
 use OCP\IUserManager;
 use OCP\Share\Exceptions\AlreadySharedException;
 use OCP\Share\Exceptions\IllegalIDChangeException;
@@ -852,9 +851,7 @@ public function getUsersForShare(IShare $share): iterable {
 		$members = $this->shareWrapperService->getShareById((int)$share->getId())->getCircle()->getInheritedMembers();
 		foreach ($members as $member) {
 			if ($member->getUserType() === Member::TYPE_USER) {
-				/** @var IUser $user */
-				$user = $this->userManager->get($member->getUserId());
-				yield $user;
+				yield $this->userManager->getExistingUser($member->getUserId());
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,6 @@`
`52`	`52`	`use OCP\Files\NotFoundException;`
`53`	`53`	`use OCP\IL10N;`
`54`	`54`	`use OCP\IURLGenerator;`
`55`		`-use OCP\IUser;`
`56`	`55`	`use OCP\IUserManager;`
`57`	`56`	`use OCP\Share\Exceptions\AlreadySharedException;`
`58`	`57`	`use OCP\Share\Exceptions\IllegalIDChangeException;`
`@@ -852,9 +851,7 @@ public function getUsersForShare(IShare $share): iterable {`
`852`	`851`	`$members = $this->shareWrapperService->getShareById((int)$share->getId())->getCircle()->getInheritedMembers();`
`853`	`852`	`foreach ($members as $member) {`
`854`	`853`	`if ($member->getUserType() === Member::TYPE_USER) {`
`855`		`- /** @var IUser $user */`
`856`		`- $user = $this->userManager->get($member->getUserId());`
`857`		`- yield $user;`
	`854`	`+ yield $this->userManager->getExistingUser($member->getUserId());`
`858`	`855`	`}`
`859`	`856`	`}`
`860`	`857`	`}`