Merge pull request #2387 from nextcloud/i2h3/fix/9690491-circles-loopback

fix(loopback): circles:check always fails due to APCu race and missing CLI wrapper

Author: i2h3

lib/Command/CirclesCheck.php

@@ -256,11 +256,12 @@ private function setupLoopback(InputInterface $input, OutputInterface $output, s
 	 * @throws UnknownRemoteException
 	 */
 	private function testLoopback(InputInterface $input, OutputInterface $output): bool {
+		$this->appConfig->setValueInt(Application::APP_ID, 'test_dummy_token', time() + 10);
+
 		if (!$this->testRequest($output, 'GET', 'core.CSRFToken.index')) {
 			return false;
 		}
 
-		$this->appConfig->setValueInt(Application::APP_ID, 'test_dummy_token', time() + 10);
 		if (!$this->testRequest(
 			$output, 'POST', 'circles.EventWrapper.asyncBroadcast',
 			['token' => 'test-dummy-token']

lib/Service/FederatedEventService.php

@@ -344,7 +344,9 @@ private function configureEvent(FederatedEvent $event, IFederatedItem $item) {
 	public function initBroadcast(FederatedEvent $event): bool {
 		$instances = $this->getInstances($event);
 		// if empty instance and ran from CLI, any action as already been managed
-		if (empty($instances) && (!$event->isAsync() || OC::$CLI)) {
+		// except for loopback tests which need async verification even from CLI
+		$isLoopbackTest = is_a($event->getClass(), IFederatedItemLoopbackTest::class, true);
+		if (empty($instances) && (!$event->isAsync() || (OC::$CLI && !$isLoopbackTest))) {
 			return false;
 		}