Makefile: Refactor publish* targets to use GitHub CLI instead

Author: PhrozenByte

Makefile

@@ -11,11 +11,9 @@
 # - Target 'verify'
 #       Requires OpenSSL and a RSA public key to verify the release archive at
 #       '~/.nextcloud/certificates/$(app_name).pub'
-# - Targets 'github-release' and 'github-upload'
-#       Requires https://github.com/aktau/github-release and a 'github-token'
-#       file at '~/.nextcloud/github-token' with an GitHub API token, e.g.
-#           deadbeefc001cafebaadf00dabad1deadeadcode
-# - Target 'publish'
+# - Targets 'publish-github'
+#       Requires GitHub CLI with working authentication (see https://cli.github.com/)
+# - Target 'publish-appstore'
 #       Requires a 'curlrc' file at '~/.nextcloud/curlrc' with an appropiate
 #       Authentication header for the Nextcloud App Store, e.g.
 #           header = "Authorization: Token [NEXTCLOUD_API_TOKEN]"
@@ -39,10 +37,7 @@ archive=$(app_name)-$(version).tar.gz
 export=$(app_name)-export.tar.gz
 signature=$(app_name)-$(version).tar.gz.sig
 git_remote=origin
-github_owner=nextcloud
-github_repo=cms_pico
-github_token:=$(shell [ -n "$$GITHUB_TOKEN" ] && echo "$$GITHUB_TOKEN" || cat "$(HOME)/.nextcloud/github-token")
-download_url=https://github.com/$(github_owner)/$(github_repo)/releases/download/$(version)/$(archive)
+download_url=https://github.com/nextcloud/cms_pico/releases/download/$(version)/$(archive)
 publish_url=https://apps.nextcloud.com/api/v1/apps/releases
 appinfo=./appinfo/info.xml
 appinfo_version:=$(shell sed -ne 's/^.*<version>\(.*\)<\/version>.*$$/v\1/p' "$(CURDIR)/$(appinfo)")
@@ -159,48 +154,35 @@ test:
 coverage: test
 	$(php) -f ./vendor/bin/coverage -- ./tests/clover.xml 0
 
-github-release: export GITHUB_TOKEN=$(github_token)
-github-release: check
-	github-release release \
-		--user "$(github_owner)" \
-		--repo "$(github_repo)" \
-		--tag "$(version)" \
-		--name "$(version)" \
-		--description "$(app_title) $(version)" \
-		$(if $(filter true,$(prerelease)),--pre-release,)
-
-github-upload: export GITHUB_TOKEN=$(github_token)
-github-upload: check check-composer build github-release
-	github-release upload \
-		--user "$(github_owner)" \
-		--repo "$(github_repo)" \
-		--tag "$(version)" \
-		--name "$(archive)" \
-		--file "$(build_dir)/$(archive)"
-
-publish: check check-composer sign github-upload
-	sleep 5
+publish-github: check check-composer build
+	gh release create "$(version)" \
+		--title "$(version)" \
+		--notes "$(app_title) $(version)" \
+		$(if $(filter true,$(prerelease)),--prerelease,) \
+		"$(build_dir)/$(archive)"
+
+publish-github-dev: prerelease=true
+publish-github-dev: publish-github
+
+publish-appstore: check check-composer sign publish-github
 	$(php) -r 'echo json_encode([ "download" => $$_SERVER["argv"][1], "signature" => file_get_contents($$_SERVER["argv"][2]), "nightly" => !!$$_SERVER["argv"][3] ]);' \
 		"$(download_url)" "$(build_dir)/$(signature)" "$(if $(filter true,$(prerelease)),1,0)" \
 			| curl -K "$(curlrc)" \
 				-H "Content-Type: application/json" -d "@-" \
 				-X POST "$(publish_url)"
 
-github-release-dev: prerelease=true
-github-release-dev: github-release
-
-github-upload-dev: prerelease=true
-github-upload-dev: github-upload
+publish-appstore-dev: prerelease=true
+publish-appstore-dev: publish-appstore
 
-publish-dev: prerelease=true
-publish-dev: publish
+publish: publish-appstore
+publish-dev: publish-appstore-dev
 
 .PHONY: all \
 	clean clean-build clean-export \
 	check check-composer lazy-check \
 	composer build build-dev export \
 	sign verify \
 	test coverage \
-	github-release github-release-dev \
-	github-upload github-upload-dev \
+	publish-github publish-github-dev \
+	publish-appstore publish-appstore-dev \
 	publish publish-dev