Skip to content

Commit 145f9af

Browse files
authored
Merge pull request #4602 from nextcloud/chore/css-logical
make rtl checks error level and apply fixes
2 parents b8132de + 8590f5a commit 145f9af

File tree

3 files changed

+33
-6
lines changed

3 files changed

+33
-6
lines changed

src/components/ChartTemplate.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,8 @@ export default {
121121
margin: -34px -1px 0 -1px;
122122
background-color: var(--color-primary-element);
123123
height: 15px;
124-
border-top-left-radius: var(--border-radius-large);
125-
border-top-right-radius: var(--border-radius-large);
124+
border-start-start-radius: var(--border-radius-large);
125+
border-start-end-radius: var(--border-radius-large);
126126
}
127127
}
128128
</style>

src/components/CircleDetails.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ export default {
441441
}
442442
443443
.circle-details__main-content {
444-
margin-left: 99px;
444+
margin-inline-start: 99px;
445445
}
446446
}
447447
@@ -507,7 +507,7 @@ export default {
507507
508508
// Remove left padding added in ListItem (external component)
509509
:deep(.list-item__wrapper) {
510-
padding-left: 0;
510+
padding-inline-start: 0;
511511
}
512512
513513
.resource {

stylelint.config.cjs

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,33 @@
22
* SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
33
* SPDX-License-Identifier: AGPL-3.0-or-later
44
*/
5-
const stylelintConfig = require('@nextcloud/stylelint-config')
65

7-
module.exports = stylelintConfig
6+
module.exports = {
7+
extends: '@nextcloud/stylelint-config',
8+
plugins: ['stylelint-use-logical'],
9+
// TODO: Remove this when the Nextcloud stylelint config is updated to include this rule (planned)
10+
rules: {
11+
'csstools/use-logical': [
12+
'always',
13+
{
14+
severity: 'error',
15+
// Only lint LTR-RTL properties for now
16+
except: [
17+
// Position properties
18+
'top',
19+
'bottom',
20+
// Position properties with directional suffixes
21+
/-top$/,
22+
/-bottom$/,
23+
// Size properties
24+
'width',
25+
'max-width',
26+
'min-width',
27+
'height',
28+
'max-height',
29+
'min-height',
30+
],
31+
},
32+
],
33+
},
34+
}

0 commit comments

Comments
 (0)