Skip to content

Commit 491f76e

Browse files
committed
chore: align small review cleanups with main
Signed-off-by: Jaggob <37583151+Jaggob@users.noreply.github.com>
1 parent 6842d16 commit 491f76e

File tree

3 files changed

+1
-24
lines changed

3 files changed

+1
-24
lines changed

lib/DAV/Calendar.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ private function getBackendChildren() {
187187

188188
if ($this->board) {
189189
if ($this->stack !== null) {
190-
$this->children = $this->backend->getChildrenForStack($this->stack->getId());
190+
$this->children = $this->stack->getCards() ?? [];
191191
} else {
192192
$this->children = $this->backend->getChildren($this->board->getId());
193193
}

lib/DAV/DeckCalendarBackend.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ public function getBoards(): array {
6060
return $this->boardService->findAll(-1, false, false);
6161
}
6262

63-
/** @psalm-suppress InvalidThrow */
6463
public function getBoard(int $id): Board {
6564
try {
6665
return $this->boardService->find($id);
@@ -147,15 +146,6 @@ public function findCalendarObjectByName(string $name, ?int $boardId = null, ?in
147146
return null;
148147
}
149148

150-
/** @return Card[] */
151-
public function getChildrenForStack(int $stackId): array {
152-
return $this->stackService->find($stackId)->getCards() ?? [];
153-
}
154-
155-
public function getCalDavListMode(): string {
156-
return $this->configService->getCalDavListMode();
157-
}
158-
159149
public function getCalendarRevisionFingerprint(int $boardId, ?int $stackId = null): string {
160150
$mode = $this->configService->getCalDavListMode();
161151
$fingerprint = [$mode];

src/main.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -41,19 +41,6 @@ Vue.config.errorHandler = (err, vm, info) => {
4141
console.error(err)
4242
}
4343

44-
// TODO: remove when we have a proper fileinfo standalone library
45-
// original scripts are loaded from
46-
// https://github.com/nextcloud/server/blob/5bf3d1bb384da56adbf205752be8f840aac3b0c5/lib/private/legacy/template.php#L120-L122
47-
window.addEventListener('DOMContentLoaded', () => {
48-
if (!window.OCA.Files) {
49-
window.OCA.Files = {}
50-
}
51-
// register unused client for the sidebar to have access to its parser methods
52-
const filesApi = window.OC && window.OC.Files
53-
if (filesApi && typeof filesApi.getClient === 'function') {
54-
Object.assign(window.OCA.Files, { App: { fileList: { filesClient: filesApi.getClient() } } }, window.OCA.Files)
55-
}
56-
})
5744
/* eslint-disable-next-line no-new */
5845
new Vue({
5946
el: '#content',

0 commit comments

Comments
 (0)