chore(test): add test for receiving the root file ID during sync

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Author: nilsding

test/syncenginetestutils.cpp

@@ -1223,7 +1223,7 @@ void FakeQNAM::setServerVersion(const QString &version)
     _serverVersion = version;
 }
 
-FakeFolder::FakeFolder(const FileInfo &fileTemplate, const OCC::Optional<FileInfo> &localFileInfo, const QString &remotePath)
+FakeFolder::FakeFolder(const FileInfo &fileTemplate, const OCC::Optional<FileInfo> &localFileInfo, const QString &remotePath, const bool performInitialSync)
     : _tempDirLocalPath(QFileInfo(_tempDir.path()).canonicalFilePath())
     , _localModifier(_tempDirLocalPath)
 {
@@ -1263,10 +1263,12 @@ FakeFolder::FakeFolder(const FileInfo &fileTemplate, const OCC::Optional<FileInf
     // Ensure we have a valid VfsOff instance "running"
     switchToVfs(_syncEngine->syncOptions()._vfs);
 
-    // A new folder will update the local file state database on first sync.
-    // To have a state matching what users will encounter, we have to a sync
-    // using an identical local/remote file tree first.
-    ENFORCE(syncOnce());
+    if (performInitialSync) {
+        // A new folder will update the local file state database on first sync.
+        // To have a state matching what users will encounter, we have to a sync
+        // using an identical local/remote file tree first.
+        ENFORCE(syncOnce());
+    }
 }
 
 void FakeFolder::switchToVfs(QSharedPointer<OCC::Vfs> vfs)

test/syncenginetestutils.h

@@ -604,7 +604,7 @@ class FakeFolder
     QString _serverVersion = QStringLiteral("10.0.0");
 
 public:
-    FakeFolder(const FileInfo &fileTemplate, const OCC::Optional<FileInfo> &localFileInfo = {}, const QString &remotePath = {});
+    FakeFolder(const FileInfo &fileTemplate, const OCC::Optional<FileInfo> &localFileInfo = {}, const QString &remotePath = {}, const bool performInitialSync = true);
 
     void switchToVfs(QSharedPointer<OCC::Vfs> vfs);
 

test/testremotediscovery.cpp

@@ -221,6 +221,26 @@ private slots:
         QCOMPARE(completeSpy.findItem("unlimited")->_folderQuota.bytesAvailable, -3);
         QCOMPARE(completeSpy.findItem("invalidValue")->_folderQuota.bytesAvailable, -1);
     }
+
+    void testRootFileIdReceived()
+    {
+        // disable FakeFolder's initial sync run to allow for spying on the `rootFileIdReceived` signal
+        FakeFolder fakeFolder{ FileInfo::A12_B12_C12_S12(), {}, {}, false };
+
+        QSignalSpy rootFileIdSpy(&fakeFolder.syncEngine(), &SyncEngine::rootFileIdReceived);
+        QVERIFY(fakeFolder.syncOnce());
+
+        // root file id signal should only be emitted once
+        QCOMPARE(rootFileIdSpy.size(), 1);
+        const auto expectedRootFileId = fakeFolder.currentRemoteState().numericFileId();
+        const auto receivedRootFileId = QByteArray::number(rootFileIdSpy.takeFirst().at(0).toLongLong(), 10);
+        QCOMPARE(receivedRootFileId, expectedRootFileId);
+
+        // another sync should not emit the root file id signal again as it's already known
+        rootFileIdSpy.clear();
+        QVERIFY(fakeFolder.syncOnce());
+        QCOMPARE(rootFileIdSpy.size(), 0);
+    }
 };
 
 QTEST_GUILESS_MAIN(TestRemoteDiscovery)