refactor(propagateupload): use std::ranges::remove instead of iterator pair

solracsf · solracsf · commit d27a8412b8cc · 2026-04-03T21:32:32.000+02:00
Signed-off-by: Git'Fellow &lt;12234510+solracsf@users.noreply.github.com&gt;
diff --git a/src/libsync/propagateupload.cpp b/src/libsync/propagateupload.cpp
@@ -744,7 +744,7 @@ void PropagateUploadFileCommon::adjustLastJobTimeout(AbstractNetworkJob *job, qi
 
 void PropagateUploadFileCommon::slotJobDestroyed(QObject *job)
 {
-    _jobs.erase(std::remove(_jobs.begin(), _jobs.end(), job), _jobs.end());
+    _jobs.erase(std::ranges::remove(_jobs, job).begin(), _jobs.end());
 }
 
 // This function is used whenever there is an error occurring and jobs might be in progress

Original file line number	Diff line number	Diff line change
`@@ -744,7 +744,7 @@ void PropagateUploadFileCommon::adjustLastJobTimeout(AbstractNetworkJob *job, qi`
`744`	`744`
`745`	`745`	`void PropagateUploadFileCommon::slotJobDestroyed(QObject *job)`
`746`	`746`	`{`
`747`		`- _jobs.erase(std::remove(_jobs.begin(), _jobs.end(), job), _jobs.end());`
	`747`	`+ _jobs.erase(std::ranges::remove(_jobs, job).begin(), _jobs.end());`
`748`	`748`	`}`
`749`	`749`
`750`	`750`	`// This function is used whenever there is an error occurring and jobs might be in progress`