fix(file-provider): reuse stored macOS domain identifier - #10748
Closed
guillebot wants to merge 1 commit into
Closed
fix(file-provider): reuse stored macOS domain identifier#10748guillebot wants to merge 1 commit into
guillebot wants to merge 1 commit into
Conversation
Minting a new UUID when getDomains fails or the stored domain is temporarily missing creates a second Finder location. Re-add with the same identifier, and abort instead of minting if listing fails. Assisted-by: Cursor:grok-4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
guillebot
requested review from
camilasan,
claucambra,
i2h3,
mgallien and
nilsding
as code owners
September 4, 2026 15:28
Collaborator
|
@guillebot You have not followed the submission guidelines. Please update the PR to provide a proper description |
Collaborator
|
Also, this would reintroduce one of the single most severe mistakes in managing file providers: reusing identifiers for domains. 鈽狅笍 Reusing identifiers means also reusing possibly messed up state on the file provider framework side. 馃槵 This was an intentional change I introduced in summer 2025 and must not be reverted. Also based on experience at previous companies with other file provider projects. UUID as lifetime identifiers for domains are the way to go. |
Author
|
Thank you all for the feedback. Will take it to improve my next MR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...