Draft
Conversation
i2h3
requested review from
Aiiaiiio,
camilasan,
mgallien and
nilsding
as code owners
i2h3
added
os: 🍎 macOS
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the Xcode workspace for the Nextcloud Desktop Client project by moving it to the project root and standardizing build artifact locations. The changes remove obsolete workspace files and an unused folder, while adding comprehensive documentation for the new workspace setup.
Changes:
- Centralized derived data directories for Xcode (
.xcode) and Mac Crafter (.mac-crafter) to the project root - Created new Xcode workspace at project root with documentation
- Removed obsolete
OwnCloudFinderSyncfolder and old workspace files
Reviewed changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shell_integration/MacOSX/OwnCloudFinderSync/desktopclient/main.m | Removed obsolete fake application bundle file |
| shell_integration/MacOSX/NextcloudIntegration/NextcloudIntegration.xcodeproj/project.pbxproj | Removed reference to src folder from Xcode project |
| shell_integration/MacOSX/NextcloudIntegration/NextcloudDev/Craft.sh | Updated build path to use new .mac-crafter directory |
| shell_integration/MacOSX/Nextcloud.xcworkspace/xcshareddata/OwnCloud.xccheckout | Removed obsolete workspace checkout file |
| shell_integration/MacOSX/Nextcloud.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist | Simplified workspace checks configuration |
| doc/xcode-workspace.md | Added comprehensive documentation for the new Xcode workspace |
| README.md | Updated with Xcode workspace information and restructured build instructions |
| Nextcloud Desktop Client.xcworkspace/xcshareddata/swiftpm/Package.resolved | Added Swift package dependencies resolution file |
| AGENTS.md | Added new build artifact directories to ignore list |
| .gitignore | Updated to ignore new build directories and removed obsolete entries |
Files not reviewed (2)
- Nextcloud Desktop Client.xcworkspace/contents.xcworkspacedata: Language not supported
- shell_integration/MacOSX/Nextcloud.xcworkspace/contents.xcworkspacedata: Language not supported
Comments suppressed due to low confidence (1)
README.md:79
- Corrected spelling of 'eview' to 'review'.
3. ⬆ Create a [pull request](https://opensource.guide/how-to-contribute/#opening-a-pull-request) and `@mention` the people from the issue to eview
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Derived data directory ".xcode" for Xcode workspace in project root. - Mac crafter build directory ".mac-crafter" in project root. - Added all Swift packages and Xcode projects to workspace. - Added some important top-level files and other directories. - Removed obsolete Xcode workspace in shell integration directory. - Removed obsolete OwnCloudFinderSync folder. - Updated AGENTS.md. - Updated README.md. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
i2h3
force-pushed
the
i2h3/feature/9435-xcode-workspace
branch
from
625b16f to
04ebf1a
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9474.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9435