Conversation
i2h3
commented
Feb 20, 2026
- Raised required macOS version to 13 for Swift packages.
- Removed fallback code switches for macOS and file provider framework releases before macOS 13.
- Consolidated Xcode project build settings into single declaration in build settings file.
There was a problem hiding this comment.
Pull request overview
This pull request raises the minimum supported macOS version from 12.0 (Monterey) to 13.0 (Ventura) across the entire codebase. This change enables removal of version availability checks and fallback code that was previously needed to support macOS 12 and earlier versions. The update simplifies the codebase by eliminating conditional compilation for older APIs.
Changes:
- Updated minimum macOS version to 13.0 in all build configuration files (Package.swift, CMakeLists.txt, xcconfig, plist)
- Removed
@available(macOS 13.0, *)andif #available(macOS 13.0, *)version checks throughout Swift and Objective-C++ code - Consolidated Xcode project build settings by removing duplicate MACOSX_DEPLOYMENT_TARGET declarations
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Package.swift (multiple) | Updated Swift package minimum platform version from .macOS(.v12) to .macOS(.v13) |
| CMakeLists.txt | Updated CMAKE_OSX_DEPLOYMENT_TARGET from 12.0 to 13.0 |
| craftmaster.ini | Updated MacDeploymentTarget from 12.0 to 13.0 |
| MacOSXBundleInfo.plist.in | Updated LSMinimumSystemVersion from 12.0 to 13.0 |
| Build.xcconfig | Added centralized MACOSX_DEPLOYMENT_TARGET=13.0 declaration |
| project.pbxproj | Removed duplicate MACOSX_DEPLOYMENT_TARGET=12.0 declarations from individual targets |
| fileproviderxpc_mac_utils.mm | Removed macOS 13.0 availability check in getFileProviderServices, using newer API directly |
| fileprovideritemmetadata_mac.mm | Removed macOS 12.0 availability check for typeAndCreator property access |
| fileproviderdomainmanager.mm | Removed macOS 13.0 availability check for supportsSyncingTrash property |
| ShareTableItemView.swift | Removed macOS 12.0 availability check for hierarchicalColor configuration |
| NKShare+Extensions.swift | Removed macOS 12.0 availability check for paletteColors configuration |
| FileProviderExtension.swift | Removed macOS 13.0 availability check for .excludedFromSync error handling |
| ItemPropertyTests.swift | Removed macOS 11.3 availability checks for .allowsExcludingFromSync capability tests |
| ItemModifyTests.swift | Removed macOS 13.0 availability check for .excludedFromSync error expectation |
| ItemCreateTests.swift | Removed macOS 13.0 availability check for .excludedFromSync error expectation |
| ItemMetadata.swift | Removed macOS 13.0 availability check for thumbnailUrl URL construction |
| Item.swift | Removed multiple version checks for capabilities, userInfo, and keepDownloaded properties |
| Item+Trash.swift | Removed macOS 11.3 availability checks for .unsyncedEdits error returns |
| Item+Modify.swift | Removed macOS 13.0 availability check for .excludedFromSync error return |
| Item+LockFile.swift | Removed macOS 13.0 availability checks for .excludedFromSync error returns |
| Item+KeepDownloaded.swift | Removed macOS 13.0 availability check for requestDownloadForItem/requestModification calls |
| Item+Ignored.swift | Removed macOS 13.0 availability check for .excludedFromSync error return |
| Item+Fetch.swift | Removed macOS 13.0 availability check for lock file error handling |
| FilesDatabaseManager+KeepDownloaded.swift | Removed macOS 13.0 guard preventing keepDownloaded updates on older versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ation/MacOSX/NextcloudFileProviderKit/Sources/NextcloudFileProviderKit/Item/Item+Fetch.swift
Outdated
Show resolved
Hide resolved
...integration/MacOSX/NextcloudFileProviderKit/Sources/NextcloudFileProviderKit/Item/Item.swift
Show resolved
Hide resolved
- Raised required macOS version to 13 for Swift packages. - Removed fallback code switches for macOS and file provider framework releases before macOS 13. - Consolidated Xcode project build settings into single declaration in build settings file. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
df2b3d7 to
78f36bf
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9477.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|


