Skip to content

allow closing search by Escape key #761

@KiaraGrouwstra

Description

@KiaraGrouwstra

Steps to reproduce

  1. open search
  2. press Escape to hopefully close search again by keyboard without having to resort to using the mouse
  3. search won't close

Expected behaviour

search closes

Actual behaviour

search won't close

Server configuration

Operating system:
Ubuntu

Web server:
Apache

Database:
PostgreSQL

PHP version: 8.0.16

Nextcloud version: 24.0

Where did you install Nextcloud from: using the command-line as per official instructions

List of activated apps:

Enabled:
  - accessibility: 1.10.0
  - activity: 2.16.0
  - announcementcenter: 6.3.1
  - appointments: 1.14.11
  - bbb: 2.4.0
  - bruteforcesettings: 2.4.0
  - calendar: 3.5.5
  - circles: 24.0.1
  - cloud_federation_api: 1.7.0
  - collectives: 1.6.3
  - comments: 1.14.0
  - contacts: 4.2.5
  - contactsinteraction: 1.5.0
  - dashboard: 7.4.0
  - dav: 1.22.0
  - deck: 1.7.3
  - encryption: 2.12.0
  - external: 4.0.1
  - federatedfilesharing: 1.14.0
  - federation: 1.14.0
  - files: 1.19.0
  - files_accesscontrol: 1.14.1
  - files_antivirus: 4.0.2
  - files_external: 1.16.1
  - files_markdown: 2.3.6
  - files_pdfviewer: 2.5.0
  - files_rightclick: 1.3.0
  - files_sharing: 1.16.2
  - files_texteditor: 2.15.0
  - files_trashbin: 1.14.0
  - files_versions: 1.17.0
  - files_videoplayer: 1.13.0
  - firstrunwizard: 2.13.0
  - forms: 2.5.2
  - groupfolders: 12.0.3
  - jitsi: 0.15.0
  - logreader: 2.9.0
  - lookup_server_connector: 1.12.0
  - mail: 1.15.2
  - nextcloud_announcements: 1.13.0
  - notes: 4.5.1
  - notifications: 2.12.0
  - oauth2: 1.12.0
  - password_policy: 1.14.0
  - photos: 1.6.0
  - polls: 3.8.4
  - privacy: 1.8.0
  - provisioning_api: 1.14.0
  - ransomware_protection: 1.14.0
  - richdocuments: 6.3.4
  - richdocumentscode: 22.5.802
  - serverinfo: 1.14.0
  - settings: 1.6.0
  - sharebymail: 1.14.0
  - spreed: 14.0.9
  - systemtags: 1.14.0
  - talk_matterbridge: 1.25.2
  - tasks: 0.14.5
  - text: 3.5.1
  - theming: 1.15.0
  - theming_customcss: 1.12.0
  - twofactor_backupcodes: 1.13.0
  - twofactor_gateway: 0.20.0
  - twofactor_totp: 6.4.1
  - twofactor_webauthn: 0.3.3
  - updatenotification: 1.14.0
  - user_ldap: 1.14.1
  - user_oidc: 1.3.1
  - user_status: 1.4.0
  - viewer: 1.8.0
  - weather_status: 1.4.0
  - workflowengine: 2.6.0
Disabled:
  - admin_audit
  - recommendations: 1.2.0
  - registration: 1.5.0
  - support: 1.6.0
  - survey_client: 1.11.0

Nextcloud configuration:

{
    "system": {
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost",
            "cloud.bij1.org"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "version": "24.0.4.1",
        "overwrite.cli.url": "https:\/\/cloud.bij1.org",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "default_language": "nl",
        "default_locale": "nl_NL",
        "overwriteprotocol": "https",
        "debug": "true",
        "default_phone_region": "NL",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": "6379"
        },
        "mail_smtpmode": "smtp",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "587",
        "mail_smtpsecure": "tls",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_user": "nextcloud",
        "mail_from": "nextcloud",
        "mail_sendmailmode": "smtp",
        "mail_smtpauth": 1,
        "mail_smtpauthtype": "PLAIN",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "maintenance": false,
        "theme": "",
        "loglevel": 2,
        "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory",
        "app_install_overwrite": [
            "files_texteditor"
        ],
        "twofactor_enforced": "false",
        "twofactor_enforced_groups": [],
        "twofactor_enforced_excluded_groups": []
    }
}

Client configuration

Browser: Firefox

Operating system: NixOS

Logs

Nextcloud log (data/owncloud.log)

function":"scan","class":"OCA\\Files_Antivirus\\Scanner\\ScannerBase","type":"->"},{"file":"/var/www/nextcloud/apps/files_antivirus/lib/BackgroundJob/BackgroundScanner.php","line":161,"function":"scanOneFile","class":"OCA\\Files_Antivirus\\BackgroundJob\\BackgroundScanner","type":"->"},{"file":"/var/www/nextcloud/lib/public/BackgroundJob/Job.php","line":79,"function":"run","class":"OCA\\Files_Antivirus\\BackgroundJob\\BackgroundScanner","type":"->"},{"file":"/var/www/nextcloud/lib/public/BackgroundJob/TimedJob.php","line":95,"function":"execute","class":"OCP\\BackgroundJob\\Job","type":"->"},{"file":"/var/www/nextcloud/cron.php","line":151,"function":"execute","class":"OCP\\BackgroundJob\\TimedJob","type":"->"}],"File":"/var/www/nextcloud/lib/private/Log/ErrorHandler.php","Line":99,"CustomMessage":"--"}}
{"reqId":"pJnqRCTkFYPqwOgCoULw","level":3,"time":"2023-08-22T09:00:13+00:00","remoteAddr":"","user":"--","app":"files_antivirus","method":"","url":"--","message":"OCA\\Files_Antivirus\\BackgroundJob\\BackgroundScanner::run, exception: Cannot connect to \"/var/run/clamav/clamd.ctl\": Connection refused (code 111)","userAgent":"--","version":"24.0.4.1","data":{"app":"files_antivirus"}}
{"reqId":"pJnqRCTkFYPqwOgCoULw","level":3,"time":"2023-08-22T09:00:13+00:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"stream_socket_client(): Unable to connect to unix:///var/run/clamav/clamd.ctl (Connection refused) at /var/www/nextcloud/apps/files_antivirus/lib/Scanner/ExternalClam.php#39","userAgent":"--","version":"24.0.4.1","exception":{"Exception":"Error","Message":"stream_socket_client(): Unable to connect to unix:///var/run/clamav/clamd.ctl (Connection refused) at /var/www/nextcloud/apps/files_antivirus/lib/Scanner/ExternalClam.php#39","Code":0,"Trace":[{"function":"onAll","class":"OC\\Log\\ErrorHandler","type":"::"},{"file":"/var/www/nextcloud/apps/files_antivirus/lib/Scanner/ExternalClam.php","line":39,"function":"stream_socket_client"},{"file":"/var/www/nextcloud/apps/files_antivirus/lib/Scanner/ScannerBase.php","line":86,"function":"initScanner","class":"OCA\\Files_Antivirus\\Scanner\\ExternalClam","type":"->"},{"file":"/var/www/nextcloud/apps/files_antivirus/lib/BackgroundJob/BackgroundScanner.php","line":313,"function":"scan","class":"OCA\\Files_Antivirus\\Scanner\\ScannerBase","type":"->"},{"file":"/var/www/nextcloud/apps/files_antivirus/lib/BackgroundJob/BackgroundScanner.php","line":161,"function":"scanOneFile","class":"OCA\\Files_Antivirus\\BackgroundJob\\BackgroundSca
nner","type":"->"},{"file":"/var/www/nextcloud/lib/public/BackgroundJob/Job.php","line":79,"function":"run","class":"OCA\\Files_Antivirus\\BackgroundJob\\BackgroundScanner","type":"->"},{"file":"/var/www/nextcloud/lib/public/BackgroundJob/TimedJob.php","line":95,"function":"execute","class":"OCP\\BackgroundJob\\Job","type":"->"},{"file":"/var/www/nextcloud/cron.php","line":151,"function":"execute","
class":"OCP\\BackgroundJob\\TimedJob","type":"->"}],"File":"/var/www/nextcloud/lib/private/Log/ErrorHandler.php","Line":99,"CustomMessage":"--"}}
{"reqId":"pJnqRCTkFYPqwOgCoULw","level":3,"time":"2023-08-22T09:00:13+00:00","remoteAddr":"","user":"--","app":"files_antivirus","method":"","url":"--","message":"OCA\\Files_Antivirus\\BackgroundJob\\BackgroundScanner::run, exception: Cannot connect to \"/var/run/clamav/clamd.ctl\": Connection refused (code 111)","userAgent":"--","version":"24.0.4.1","data":{"app":"files_antivirus"}}

Browser log

$ is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 672 globals.js:62:15
[DEBUG] unified-search: Searching aa in 
Object { 0: "settings_apps", 1: "files", 2: "comments", 3: "collectives", 4: "collectives-pages", 5: "collectives-page-content", 6: "circles", 7: "deck", 8: "deck-comment", 9: "talk-message", … }
ConsoleLogger.js:29:8
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
$ is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 75 globals.js:62:15
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
$ is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 188 globals.js:62:15
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
Got notification data App.vue:318
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
OC.requestToken changed 205Lz+SY+y7Of80gcSyKPs44jkQd2v3rPs14+M4FORg=:oycfgLz2s2i+SYwVG2LeS6YI6TR4mbvbW68csb9ofHE= index.js:323:9
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355
$ is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 7 globals.js:62:15
$ is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 72 globals.js:62:15
No new notification data received App.vue:323
Polling interval updated to 30000 App.vue:355

related: #162

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions