fix(versions): Catch UniqueConstraintViolationException

solracsf · solracsf · commit 1c37659970e0 · 2026-02-11T12:41:59.000+01:00
Signed-off-by: Git'Fellow &lt;12234510+solracsf@users.noreply.github.com&gt;
diff --git a/lib/Versions/VersionsBackend.php b/lib/Versions/VersionsBackend.php
@@ -1,6 +1,7 @@
 <?php
 
 declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
@@ -431,7 +432,13 @@ public function importVersionsForFile(IUser $user, Node $source, Node $target, a
 				$versionEntity->setDecodedMetadata($version->getMetadata());
 			}
 
-			$this->groupVersionsMapper->insert($versionEntity);
+			try {
+				$this->groupVersionsMapper->insert($versionEntity);
+			} catch (\OCP\DB\Exception $e) {
+				if ($e->getReason() !== \OCP\DB\Exception::REASON_UNIQUE_CONSTRAINT_VIOLATION) {
+					throw $e;
+				}
+			}
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`<?php`
`2`	`2`
`3`	`3`	`declare(strict_types=1);`
	`4`	`+`
`4`	`5`	`/**`
`5`	`6`	`* SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors`
`6`	`7`	`* SPDX-License-Identifier: AGPL-3.0-or-later`
`@@ -431,7 +432,13 @@ public function importVersionsForFile(IUser $user, Node $source, Node $target, a`
`431`	`432`	`$versionEntity->setDecodedMetadata($version->getMetadata());`
`432`	`433`	`}`
`433`	`434`
`434`		`- $this->groupVersionsMapper->insert($versionEntity);`
	`435`	`+ try {`
	`436`	`+ $this->groupVersionsMapper->insert($versionEntity);`
	`437`	`+ } catch (\OCP\DB\Exception $e) {`
	`438`	`+ if ($e->getReason() !== \OCP\DB\Exception::REASON_UNIQUE_CONSTRAINT_VIOLATION) {`
	`439`	`+ throw $e;`
	`440`	`+ }`
	`441`	`+ }`
`435`	`442`	`}`
`436`	`443`	`}`
`437`	`444`